Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Libyear Parsing Function to Support More than One Dependency Manifest per Project #2943

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

IsaacMilarky
Copy link
Contributor

Description

  • Use .get instead of dictionary indices to avoid missing info in poetry.lock
  • Make each dependency function extend the dep list instead of returning once we find the first manifest file
  • Parse the path into a short string that can be more easily compared
  • Parse through all found dependency manifest files and put them all in one big dictionary

Notes for Reviewers
I have tested locally on my repos but @sgoggins you might want to test it a bit on other repos.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Isaac Milarsky <[email protected]>
@IsaacMilarky IsaacMilarky added bug Documents unexpected/wrong/buggy behavior CHAOSS Issues that relate directly to our goal of being a good reference implementation of CHAOSS metrics add-feature Adds new features labels Oct 27, 2024
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sgoggins sgoggins merged commit 0ffad01 into dev Oct 28, 2024
9 checks passed
@IsaacMilarky IsaacMilarky deleted the libyear-patch branch October 28, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-feature Adds new features bug Documents unexpected/wrong/buggy behavior CHAOSS Issues that relate directly to our goal of being a good reference implementation of CHAOSS metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants