Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing server_metadata #7346

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

fix: missing server_metadata #7346

wants to merge 14 commits into from

Conversation

Bento007
Copy link
Contributor

@Bento007 Bento007 commented Sep 27, 2024

Reason for Change

rolling back to previously working version of authlib.
Previously it was upgraded here a12556f997d9caa1cfbd52453446c5c4af460df3m which caused 502 on the frontend.

Changes

  • add server_metadata to oath config
  • roll back to previous authlib version.

Testing steps

  • verify you can login on frontend
  • all automated tests pass.

Copy link
Contributor

Deployment Summary

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.92%. Comparing base (fda46d2) to head (bbe151a).

Files with missing lines Patch % Lines
backend/common/census_cube/utils.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7346   +/-   ##
=======================================
  Coverage   92.91%   92.92%           
=======================================
  Files         194      194           
  Lines       16827    16828    +1     
=======================================
+ Hits        15635    15637    +2     
+ Misses       1192     1191    -1     
Flag Coverage Δ
unittests 92.92% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bento007 Bento007 closed this Oct 2, 2024
@Bento007 Bento007 reopened this Oct 2, 2024
Copy link
Contributor

@nayib-jose-gloria nayib-jose-gloria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're rolling back the authlib change, why do we still need to add in server metadata when its working without it?

@Bento007
Copy link
Contributor Author

Bento007 commented Oct 4, 2024

it will be needed in the future anyways according to auth0 documentation.

@nayib-jose-gloria
Copy link
Contributor

nayib-jose-gloria commented Oct 4, 2024

it will be needed in the future anyways according to auth0 documentation.

I'm still getting a 502 gateway when i try to log in on rdev

@Bento007
Copy link
Contributor Author

Bento007 commented Oct 4, 2024

Still looking for where that 502 is coming from.

  • rdev does not use cloudfront
  • I did not find any 502 in the logs for the contianer dataportal-rdev-happy-proxy
  • I can see the callback in
    pr-7346-backend and it's returning 302.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants