Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add newsletter to bottom banner (SCE-29) #7344

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kaloster
Copy link
Contributor

@kaloster kaloster commented Sep 24, 2024

Re-activated Newsletter signup in bottom banner for GE, CG and DE
Added e2e test
Added analytics + plausible
Updated Privacy Policy
Added doNotTrack for hubspot

Screenshot 2024-09-24 at 1 23 30 PM

Copy link
Contributor

Deployment Summary

@kaloster kaloster marked this pull request as draft September 24, 2024 17:29
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.93%. Comparing base (a12556f) to head (a370849).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7344      +/-   ##
==========================================
- Coverage   92.93%   92.93%   -0.01%     
==========================================
  Files         194      194              
  Lines       16822    16822              
==========================================
- Hits        15634    15633       -1     
- Misses       1188     1189       +1     
Flag Coverage Δ
unittests 92.93% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaloster kaloster marked this pull request as ready for review September 24, 2024 17:54
Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks for adding it back 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants