Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(all): refactor components and colors based on latest figma changes #902

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

masoudmanson
Copy link
Contributor

@masoudmanson masoudmanson commented Nov 22, 2024

Summary

Everything
Github issue: #901

Checklist

  • Default Story in Storybook
  • LivePreview Story in Storybook
  • Test Story in Storybook
  • Tests written
  • Variables from defaultTheme.ts used wherever possible
  • If updating an existing component, depreciate flag has been used where necessary
  • Chromatic build verified by @chanzuckerberg/sds-design

@masoudmanson masoudmanson self-assigned this Nov 22, 2024
@masoudmanson masoudmanson added Work in Progress This PR is a work in progress P0 Eng labels Nov 22, 2024
Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great overhaul and detailed updates 🙏 Thanks so much!

@masoudmanson masoudmanson added Ready for review This PR is ready for review and removed Work in Progress This PR is a work in progress labels Nov 23, 2024
@masoudmanson
Copy link
Contributor Author

Great overhaul and detailed updates 🙏 Thanks so much!

Wow, that was such a quick review 😯 thank you so much, @tihuan! 🥳🎉😍✨

Copy link

@clarsen-czi clarsen-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking so good @masoudmanson! Just a few small changes to make.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Eng P0 Ready for review This PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Theme and Variables based on Updated Color Design in Figma
3 participants