New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(navigationbar): add new component #729

Closed

booc0mtaco wants to merge 1 commit into main from aholloway/x-add-navbar-component

booc0mtaco commented Nov 30, 2023

Summary

Structural Element (Base, Gene, DNA, Chromosome or Cell)
Github issue: #728

WIP, support API for modifying home image, links, and responsiveness

Checklist

Default Story in Storybook
LivePreview Story in Storybook
Test Story in Storybook
Tests written
Variables from defaultTheme.ts used wherever possible
If updating an existing component, deprecate flag has been used where necessary
Chromatic build verified by @chanzuckerberg/sds-design


          feat(navigationbar): add new component

0d387be

- WIP, support API for modifying home image, links, and responsiveness

re #728

Author

booc0mtaco commented Nov 30, 2023

Biohub UI Github repo: https://github.com/czbiohub-sf/czb-ui
Biohub UI Storybook: https://czb-ui.vercel.app/?path=/story/demos-of-czi-components--button
Examples of above:
- Tabula microcebus
- Zebrahub
ZeroHeight (SSO): https://sds.czi.design/009eaf17b/p/55ad7a-introduction

masoudmanson self-assigned this

masoudmanson added Hackday Design labels

masoudmanson added the Won't Fix label

Contributor

masoudmanson commented Nov 7, 2024

A new implementation is available in PR #885, so I’ll close this PR now.

masoudmanson closed this

Author

booc0mtaco commented Nov 7, 2024

@masoudmanson cool, thanks for the update & good luck. will watch the progress :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Design Hackday Won't Fix