Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: typescript migration #138

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

danivelop
Copy link
Member

No description provided.

@danivelop danivelop added the enhancement New feature or request label Dec 6, 2024
@danivelop danivelop self-assigned this Dec 6, 2024
Copy link

channeltalk bot commented Dec 6, 2024

@danivelop danivelop requested review from zoyi-jin and jam0128 December 9, 2024 07:29
@jam0128
Copy link
Contributor

jam0128 commented Dec 9, 2024

이거 기존의 js 파일 삭제는 안해도 되는건가요?

@danivelop danivelop changed the title feat: 타입스크립트 마이그레이션 feat: typescript migration Dec 9, 2024
@danivelop
Copy link
Member Author

이거 기존의 js 파일 삭제는 안해도 되는건가요?

참고를 위해 남겨두었어요! 리뷰 모두 완료되면 삭제예정입니다

@danivelop danivelop requested review from zoyi-jin and jam0128 and removed request for zoyi-jin and jam0128 December 11, 2024 07:22
Copy link
Contributor

@zoyi-jin zoyi-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

몇가지 수정사항이 있긴 한데,
제쪽에서 RN 추가작업이 필요한 부분이 있어서 그때 같이 수정하는게 더 나아보여서 우선 approve 하겠습니당

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants