Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert babel-styled-components plugin #1100

Closed

Conversation

leejiwoo2002
Copy link
Contributor

@leejiwoo2002 leejiwoo2002 commented Jan 9, 2023

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [Component] I wrote a unit test about the implementation.
  • [Component] I wrote a storybook document about the implementation.
  • [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Summary

This reverts commit 650d31b. (babel.config.js)

Details

This setting causes a hydration error during the server-side rendering process. So we have to revert.

@leejiwoo2002 leejiwoo2002 added the bug Issues related to anything that isn't working label Jan 9, 2023
@leejiwoo2002 leejiwoo2002 self-assigned this Jan 9, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2023

🦋 Changeset detected

Latest commit: 8471eb0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@leejiwoo2002 leejiwoo2002 changed the title Revert bable-styled-components plugin Revert babel-styled-components plugin Jan 9, 2023
@aooen
Copy link
Contributor

aooen commented Jan 9, 2023

이거 없애는 이유가 뭔가요?~

@leejiwoo2002
Copy link
Contributor Author

@aooen SSR 환경에서 hydration 에러를 발생시키는 오류가 있는것으로 보입니다
홈페이지쪽에 문제가 발생하여 에드와 페어 프로그래밍을 진행했고,
소스에는 문제가 없음 + 사용처에서도 별다른 설정 없음 + 오류가 발생한 시점 추적하여 확인해 본 바
위 설정을 원복하자 에러가 사라졌음을 확인했습니다

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

Chromatic Report

🚀 Congratulations! Your build was successful!

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Base: 72.61% // Head: 72.61% // No change to project coverage 👍

Coverage data is based on head (8471eb0) compared to base (b509000).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           next-v1    #1100   +/-   ##
========================================
  Coverage    72.61%   72.61%           
========================================
  Files          237      237           
  Lines         3137     3137           
  Branches       853      853           
========================================
  Hits          2278     2278           
  Misses         728      728           
  Partials       131      131           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leejiwoo2002 leejiwoo2002 added the chore:deps Issue or PR related to dependencies label Jan 9, 2023
@leejiwoo2002 leejiwoo2002 deleted the fix/bable-config branch January 9, 2023 08:19
@leejiwoo2002 leejiwoo2002 restored the fix/bable-config branch January 9, 2023 08:19
@leejiwoo2002 leejiwoo2002 reopened this Jan 9, 2023
@sungik-choi
Copy link
Contributor

Rollup 설정도 원복해야할 거 같습니다~!

@leejiwoo2002
Copy link
Contributor Author

Revert한 뒤에 PR 다시 작성하겠습니다..!

@aooen
Copy link
Contributor

aooen commented Jan 9, 2023

styled-components/babel-plugin-styled-components#351 (comment)
관련 이슈 같은데 조금만 더 찾아볼게요

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues related to anything that isn't working chore:deps Issue or PR related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants