Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nixpkgs #262

Merged
merged 1 commit into from
May 6, 2024
Merged

Update nixpkgs #262

merged 1 commit into from
May 6, 2024

Conversation

pbrinkmeier
Copy link

Hiya, I'd like to work on #236 and perhaps #159. For default values in the config, it would be cool to have access to Data.Aeson.omittedField, which was only added recently.

So this PR bumps nixpkgs to the most recent ref at the time of writing.

NB the ref contains aeson_2_2_1_0 which can be used for this purpose, but not yet for overriding aeson in the overlay. This means that after bumping nixpkgs, the closure of hoff would contain multiple versions of aeson which would have to be resolved at some later point in time.

The PR also replaces the occurrences of the deprecated Scotty action param with captureParam because it wouldn't build otherwise with newer versions of Scotty due to the deprecation warnings and -Werror.

Copy link

@FPtje FPtje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the nixpkgs update! I can imagine the Hoff nixpkgs was out of date by quite a bit.

I see that CI isn't running. Maybe asking Hoff to merge this PR kicks CI into action.

@OpsBotPrime merge

@OpsBotPrime
Copy link

Pull request approved for merge by @FPtje, rebasing now.

@OpsBotPrime
Copy link

Rebased as 646154a, waiting for CI …

@OpsBotPrime
Copy link

CI job 🟡 started.

@OpsBotPrime OpsBotPrime merged commit 646154a into channable:master May 6, 2024
1 check was pending
@pbrinkmeier pbrinkmeier deleted the update-nixpkgs branch May 6, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants