Detect failing nix builds on CI #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudymatela
added
bug
|
This is ready for review. @maartenberg, can you please take a look? |
maartenberg
approved these changes
Jun 10, 2022
Comment on lines
+86
to
+88
| # Print working directory for debugging purposes | ||
| - "pwd" | ||
|
|
There was a problem hiding this comment.
Not strictly, but I think it is useful to record the working directory since we are creating the nix-store-location file there.
|
@OpsBotPrime merge on friday 😈 afternoon 👹 |
|
Pull request approved for merge by @rudymatela, rebasing now. |
Approved-by: rudymatela Auto-deploy: false
|
Rebased as b0bf0a6, waiting for CI … |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #119
This separates the
nix-buildandcachix storesteps of the build in two commands.Previously failures in
nix-buildwere not being detected due to it not being the last command in the pipe. This PR fixes the issue by avoiding piping the two commands.