Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wngr as author #85

Merged
merged 3 commits into from
Oct 21, 2024
Merged

add wngr as author #85

merged 3 commits into from
Oct 21, 2024

Conversation

asmello
Copy link
Collaborator

@asmello asmello commented Oct 20, 2024

@asmello
Copy link
Collaborator Author

asmello commented Oct 20, 2024

We should probably have a CI check for the manifest formatting

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.1%. Comparing base (c6ceb4b) to head (e40c201).

Additional details and impacted files

see 1 file with indirect coverage changes

This was referenced Oct 20, 2024
@asmello
Copy link
Collaborator Author

asmello commented Oct 20, 2024

Interesting, looks like adding the extra key makes a big change in how taplo chooses to format the file. This is possibly a side-effect of the custom settings in .taplo.toml. Might be something we wish to correct (but then again, changes to the TOML files aren't that frequent so maybe this is ok).

@asmello asmello changed the title add wngr as author and reformat manifest using taplo add wngr as author Oct 20, 2024
@chanced
Copy link
Owner

chanced commented Oct 20, 2024

Yea, taplo isn't always consistent with formatting. Sometimes it triggers and sometimes it just flakes out.

I'll circle back and look at the config later this evening.

@chanced
Copy link
Owner

chanced commented Oct 20, 2024

@wngr just want to make sure you're cool with this before I pull it in.

@chanced
Copy link
Owner

chanced commented Oct 20, 2024

In case it wasn't obvious (it may not be) - I very much believe you should be on the authors list.

I just want to make sure you don't have any oppositions.

@wngr
Copy link

wngr commented Oct 21, 2024

Appreciate your consideration -- happy to be included! :-)

@chanced
Copy link
Owner

chanced commented Oct 21, 2024

Rock on :)

@chanced chanced merged commit c694765 into chanced:main Oct 21, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants