-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ubuntu 20.04 excluding composer and chash from git #6
Open
dbendlin
wants to merge
12
commits into
chamilo:1.11.x
Choose a base branch
from
dbendlin:feature/ubuntu-20.04-excluding-composer-and-chash-from-git
base: 1.11.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/ubuntu 20.04 excluding composer and chash from git #6
dbendlin
wants to merge
12
commits into
chamilo:1.11.x
from
dbendlin:feature/ubuntu-20.04-excluding-composer-and-chash-from-git
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd chamilo-lms -1.11.x, this file is only processed at docker build, still need to find out how to everride its content when using dockr run =/
…p instructions to get some errors, I've also changed the host and domain used by the current example.
…es, file include ARG instructions to override some values that were before hardcoded, still need to find out how to make the env variables override values when issuing docker run. This file downloads chamilo, composer and chash from github and then performs composer update producing a 3.5GB size docker image. I'm going to summit another pull request that avoids this steps. Finally openssh its removed , docker exec -it ${container_name} /bin/bash could be used in the docker host to get into the running container. Entrypoint inmplemented so container can run in detached mode
…ust use one downloaded pron githubs repo =)
…te from ubuntu repos (downt know whant i've leave behind). Git clone for both previous packages excluded from Dockerfile.. composer update -n on chamilo root also excluded. Got a docker image of only 1GB size.
…be run. This step take a while to execute. But in the end got a 1.97GB docker image.
…still hope to allow container customization throght ENV variables
The |
… suposed to maintain ${variables} so they can be substituted by docker run command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When excluding
Im getting an almost 2GB docker image that works