feat: svelte examples batch 2 #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bug: - anchor coordinates css variable is not set only for the first right click.
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
colinlienard
pushed a commit
to colinlienard/zag
that referenced
this pull request
Jun 18, 2024
* chore: only pass state to toolbar * fix: unstate machine.state for connect to guards against premature effect * feat: combobox example * chore: update svelte to latest next version * feat: clipboard example * chore: change svelte example app title to svelte machines * feat: collapsible example * feat: portal action * fix: export portal action * feat: context menu example bug: - anchor coordinates css variable is not set only for the first right click. --------- Co-authored-by: Segun Adebayo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Add the following examples for Svelte:
And
portalaction for popover.⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information
There are bugs in combobox and menu machine:
combobox.connectthat use||operator for input value. PR to fix this fix: combobox empty input should not be replaced by selected value when typing #1256.0, 0coordinate. I don't know the cause yet.