Skip to content

fix: combobox empty input should not be replaced by selected value when typing #3273

fix: combobox empty input should not be replaced by selected value when typing

fix: combobox empty input should not be replaced by selected value when typing #3273

Triggered via pull request February 17, 2024 08:26
Status Success
Total duration 2m 46s
Artifacts

quality.yml

on: pull_request
Matrix: End-to-end Tests
Fit to window
Zoom out
Zoom in

Annotations

1 error, 22 warnings, and 11 notices
dialog.e2e.ts:38:7 › dialog › should trap focus within dialog: e2e/dialog.e2e.ts#L44
1) dialog.e2e.ts:38:7 › dialog › should trap focus within dialog ───────────────────────────────── Error: Timed out 10000ms waiting for expect(locator).toBeFocused() Locator: locator('[data-testid=close\\-1]') Expected: focused Received: inactive Call log: - expect.toBeFocused with timeout 10000ms - waiting for locator('[data-testid=close\\-1]') 42 | await page.keyboard.press("Tab") 43 | await page.keyboard.press("Tab") > 44 | await expect(page.locator(dialog_1.close)).toBeFocused() | ^ 45 | }) 46 | 47 | test("should close modal on escape", async ({ page }) => { at /home/runner/work/zag/zag/e2e/dialog.e2e.ts:44:48
ESLint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: pnpm/action-setup@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Unit Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: pnpm/action-setup@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
End-to-end Tests (12)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: pnpm/action-setup@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
End-to-end Tests (9)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: pnpm/action-setup@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
End-to-end Tests (10)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: pnpm/action-setup@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
End-to-end Tests (6)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: pnpm/action-setup@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
End-to-end Tests (7)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: pnpm/action-setup@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
End-to-end Tests (1)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: pnpm/action-setup@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
TypeScript
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: pnpm/action-setup@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
End-to-end Tests (5)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: pnpm/action-setup@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Slow Test: nested-menu.e2e.ts#L1
nested-menu.e2e.ts took 16.9s
End-to-end Tests (8)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: pnpm/action-setup@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Slow Test: select.e2e.ts#L1
select.e2e.ts took 39.8s
End-to-end Tests (4)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: pnpm/action-setup@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Slow Test: dialog.e2e.ts#L1
dialog.e2e.ts took 23.4s
Slow Test: hover-card.e2e.ts#L1
hover-card.e2e.ts took 18.7s
End-to-end Tests (2)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: pnpm/action-setup@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Slow Test: combobox.e2e.ts#L1
combobox.e2e.ts took 25.0s
End-to-end Tests (11)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: pnpm/action-setup@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Slow Test: tree-view.e2e.ts#L1
tree-view.e2e.ts took 20.4s
End-to-end Tests (3)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: pnpm/action-setup@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Slow Test: date-picker.e2e.ts#L1
date-picker.e2e.ts took 25.0s
🎭 Playwright Run Summary
7 passed (15.7s)
🎭 Playwright Run Summary
23 passed (32.5s)
🎭 Playwright Run Summary
2 skipped 26 passed (35.7s)
🎭 Playwright Run Summary
21 passed (29.9s)
🎭 Playwright Run Summary
2 skipped 32 passed (42.4s)
🎭 Playwright Run Summary
18 passed (30.7s)
🎭 Playwright Run Summary
1 skipped 36 passed (54.5s)
🎭 Playwright Run Summary
1 flaky dialog.e2e.ts:38:7 › dialog › should trap focus within dialog ────────────────────────────────── 1 skipped 26 passed (57.4s)
🎭 Playwright Run Summary
23 passed (34.6s)
🎭 Playwright Run Summary
1 skipped 41 passed (53.5s)
🎭 Playwright Run Summary
12 passed (37.2s)