fix: focus outside + active element mutation #5784
Annotations
2 errors and 1 notice
Run tests:
e2e/models/popover.model.ts#L91
1) popover.e2e.ts:53:7 › popover › [keyboard / non-modal] on tab outside: should move focus to next tabbable element after button
Error: Timed out 10000ms waiting for expect(locator).toBeFocused()
Locator: locator('[data-testid=button\\-after]')
Expected: focused
Received: inactive
Call log:
- expect.toBeFocused with timeout 10000ms
- waiting for locator('[data-testid=button\\-after]')
14 × locator resolved to <button data-testid="button-after">Button :after</button>
- unexpected value "not focused"
at models/popover.model.ts:91
89 |
90 | seeButtonAfterIsFocused() {
> 91 | return expect(this.buttonAfter).toBeFocused()
| ^
92 | }
93 |
94 | seeButtonBeforeIsFocused() {
at PopoverModel.seeButtonAfterIsFocused (/home/runner/work/zag/zag/e2e/models/popover.model.ts:91:37)
at /home/runner/work/zag/zag/e2e/popover.e2e.ts:57:13
|
Run tests:
e2e/models/popover.model.ts#L79
2) popover.e2e.ts:82:7 › popover › [pointer] when clicking outside, should re-focus the button on click non-focusable element
Error: Timed out 10000ms waiting for expect(locator).toBeFocused()
Locator: locator('[data-scope=popover][data-part=trigger]')
Expected: focused
Received: inactive
Call log:
- expect.toBeFocused with timeout 10000ms
- waiting for locator('[data-scope=popover][data-part=trigger]')
14 × locator resolved to <button type="button" data-state="open" data-part="trigger" data-scope="popover" aria-expanded="true" aria-haspopup="dialog" data-placement="bottom" id="popover::R6m::trigger" data-testid="popover-trigger" aria-controls="popover::R6m::content">…</button>
- unexpected value "not focused"
at models/popover.model.ts:79
77 |
78 | seeTriggerIsFocused() {
> 79 | return expect(this.trigger).toBeFocused()
| ^
80 | }
81 |
82 | seeContentIsFocused() {
at PopoverModel.seeTriggerIsFocused (/home/runner/work/zag/zag/e2e/models/popover.model.ts:79:33)
at /home/runner/work/zag/zag/e2e/popover.e2e.ts:85:13
|
Run tests
2 flaky
popover.e2e.ts:53:7 › popover › [keyboard / non-modal] on tab outside: should move focus to next tabbable element after button
popover.e2e.ts:82:7 › popover › [pointer] when clicking outside, should re-focus the button on click non-focusable element
26 passed (1.0m)
|
Loading