test #1
ekrembalAnnotations
1 error and 28 warnings
|
Rustfmt
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
|
|
Rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
the borrowed expression implements the required traits:
src/wire.rs#L44
warning: the borrowed expression implements the required traits
--> src/wire.rs:44:25
|
44 | .push_slice(&self.hashes[1].to_le_bytes())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.hashes[1].to_le_bytes()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/wire.rs#L41
warning: the borrowed expression implements the required traits
--> src/wire.rs:41:25
|
41 | .push_slice(&self.hashes[0].to_le_bytes())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.hashes[0].to_le_bytes()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
unneeded `return` statement:
src/wire.rs#L29
warning: unneeded `return` statement
--> src/wire.rs:29:9
|
29 | / return Wire {
30 | | preimages: Some([preimage1, preimage2]),
31 | | hashes: [hash1, hash2],
32 | | selector: None,
33 | | };
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
29 ~ Wire {
30 + preimages: Some([preimage1, preimage2]),
31 + hashes: [hash1, hash2],
32 + selector: None,
33 ~ }
|
|
|
you should consider adding a `Default` implementation for `Wire`:
src/wire.rs#L18
warning: you should consider adding a `Default` implementation for `Wire`
--> src/wire.rs:18:5
|
18 | / pub fn new() -> Self {
19 | | let mut rng = rand::thread_rng();
20 | |
21 | | let preimage1 = Target::from_le_bytes(rng.gen());
... |
33 | | };
34 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
help: try adding this
|
17 + impl Default for Wire {
18 + fn default() -> Self {
19 + Self::new()
20 + }
21 + }
|
|
|
unneeded `return` statement:
src/gates.rs#L61
warning: unneeded `return` statement
--> src/gates.rs:61:9
|
61 | return "NotGate".to_string();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
61 - return "NotGate".to_string();
61 + "NotGate".to_string()
|
|
|
unneeded `return` statement:
src/gates.rs#L52
warning: unneeded `return` statement
--> src/gates.rs:52:9
|
52 | / return XorGate {
53 | | input_wires,
54 | | output_wires,
55 | | };
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
52 ~ XorGate {
53 + input_wires,
54 + output_wires,
55 ~ }
|
|
|
unneeded `return` statement:
src/gates.rs#L41
warning: unneeded `return` statement
--> src/gates.rs:41:9
|
41 | return "NotGate".to_string();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
41 - return "NotGate".to_string();
41 + "NotGate".to_string()
|
|
|
unneeded `return` statement:
src/gates.rs#L32
warning: unneeded `return` statement
--> src/gates.rs:32:9
|
32 | / return AndGate {
33 | | input_wires,
34 | | output_wires,
35 | | };
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
32 ~ AndGate {
33 + input_wires,
34 + output_wires,
35 ~ }
|
|
|
unneeded `return` statement:
src/gates.rs#L21
warning: unneeded `return` statement
--> src/gates.rs:21:9
|
21 | return "NotGate".to_string();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
21 - return "NotGate".to_string();
21 + "NotGate".to_string()
|
|
|
unneeded `return` statement:
src/gates.rs#L12
warning: unneeded `return` statement
--> src/gates.rs:12:9
|
12 | / return NotGate {
13 | | input_wires,
14 | | output_wires,
15 | | };
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
12 ~ NotGate {
13 + input_wires,
14 + output_wires,
15 ~ }
|
|
|
comparison to empty slice:
src/circuit.rs#L57
warning: comparison to empty slice
--> src/circuit.rs:57:27
|
57 | } else if line_str != "" {
| ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!line_str.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
= note: `#[warn(clippy::comparison_to_empty)]` on by default
|
|
unneeded `return` statement:
src/circuit.rs#L19
warning: unneeded `return` statement
--> src/circuit.rs:19:9
|
19 | / return Circuit {
20 | | input_sizes: vec![32, 32],
21 | | output_sizes: vec![32],
22 | | gates: vec![Box::new(NotGate::new(vec![], vec![]))],
23 | | wires: vec![],
24 | | };
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
19 ~ Circuit {
20 + input_sizes: vec![32, 32],
21 + output_sizes: vec![32],
22 + gates: vec![Box::new(NotGate::new(vec![], vec![]))],
23 + wires: vec![],
24 ~ }
|
|
|
you should consider adding a `Default` implementation for `Circuit`:
src/circuit.rs#L18
warning: you should consider adding a `Default` implementation for `Circuit`
--> src/circuit.rs:18:5
|
18 | / pub fn new() -> Self {
19 | | return Circuit {
20 | | input_sizes: vec![32, 32],
21 | | output_sizes: vec![32],
... |
24 | | };
25 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
= note: `#[warn(clippy::new_without_default)]` on by default
help: try adding this
|
17 + impl Default for Circuit {
18 + fn default() -> Self {
19 + Self::new()
20 + }
21 + }
|
|
|
Clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|