Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent processing pre-proven commitments #989

Merged
merged 10 commits into from
Aug 19, 2024

Conversation

rakanalh
Copy link
Contributor

@rakanalh rakanalh marked this pull request as ready for review August 15, 2024 15:25
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 60.31746% with 25 lines in your changes missing coverage. Please review.

Project coverage is 78.7%. Comparing base (fe4cadd) to head (68547c3).
Report is 3 commits behind head on nightly.

Files Patch % Lines
...module-system/sov-modules-stf-blueprint/src/lib.rs 0.0% 16 Missing ⚠️
crates/prover/src/runner.rs 84.0% 7 Missing ⚠️
crates/citrea-stf/src/verifier.rs 0.0% 1 Missing ⚠️
...reign-sdk/full-node/sov-stf-runner/src/mock/mod.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
Files Coverage Δ
...reign-sdk/full-node/db/sov-db/src/ledger_db/mod.rs 91.3% <100.0%> (+<0.1%) ⬆️
...eign-sdk/rollup-interface/src/state_machine/stf.rs 41.3% <ø> (ø)
...n-sdk/rollup-interface/src/state_machine/zk/mod.rs 100.0% <ø> (ø)
crates/citrea-stf/src/verifier.rs 11.8% <0.0%> (-0.3%) ⬇️
...reign-sdk/full-node/sov-stf-runner/src/mock/mod.rs 0.0% <0.0%> (ø)
crates/prover/src/runner.rs 83.9% <84.0%> (-0.1%) ⬇️
...module-system/sov-modules-stf-blueprint/src/lib.rs 50.5% <0.0%> (-1.9%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Member

@eyusufatik eyusufatik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll work fine, what about just passing indices of the sequencer commitments to be skipped? does this have any benefits over that?

@rakanalh
Copy link
Contributor Author

It'll work fine, what about just passing indices of the sequencer commitments to be skipped? does this have any benefits over that?

I am passing the preproven ranges because the STF structure was also accepting ranges so i followed the same approach.

@rakanalh rakanalh merged commit f783afb into nightly Aug 19, 2024
12 checks passed
@rakanalh rakanalh deleted the rakanalh/commitment-prevent-proving-duplicates branch August 19, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip proving already proved sequencer commitments
3 participants