Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort commitments in zk #987

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Conversation

yaziciahmet
Copy link
Contributor

Description

Sorting commitments in zk env just in case.

Linked Issues

@yaziciahmet yaziciahmet requested a review from eyusufatik August 14, 2024 08:05
@yaziciahmet yaziciahmet self-assigned this Aug 14, 2024
@auto-assign auto-assign bot requested review from ercecan, jfldde, kpp and rakanalh August 14, 2024 08:05
Copy link
Member

@eyusufatik eyusufatik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aggree with rakan.

@yaziciahmet yaziciahmet requested a review from rakanalh August 14, 2024 09:25
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.0%. Comparing base (9d27b5f) to head (67073bb).
Report is 5 commits behind head on nightly.

Files Patch % Lines
...reign-sdk/rollup-interface/src/state_machine/da.rs 0.0% 6 Missing ⚠️
...module-system/sov-modules-stf-blueprint/src/lib.rs 0.0% 2 Missing ⚠️
Additional details and impacted files
Files Coverage Δ
...module-system/sov-modules-stf-blueprint/src/lib.rs 52.4% <0.0%> (-0.5%) ⬇️
...reign-sdk/rollup-interface/src/state_machine/da.rs 68.0% <0.0%> (-6.0%) ⬇️

... and 3 files with indirect coverage changes

@rakanalh rakanalh merged commit 12bb40f into nightly Aug 15, 2024
12 checks passed
@rakanalh rakanalh deleted the yaziciahmet/sort-commitments-in-zk branch August 15, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort commitments by height in zk
3 participants