Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bonsai sdk blocking client #980

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Conversation

eyusufatik
Copy link
Member

Description

Removes the bonsai sdk client wrapper queue system we have because we couldn't go async in that part.

Feels so nice 😇

# testing
I haven't tested this code even a bit @kpp please double review the macro :)

@eyusufatik eyusufatik linked an issue Aug 13, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.

Please upload report for BASE (nightly@b40e674). Learn more about missing BASE report.
Report is 4 commits behind head on nightly.

Files Patch % Lines
crates/risc0-bonsai/src/host.rs 0.0% 35 Missing ⚠️
Additional details and impacted files
Files Coverage Δ
crates/risc0-bonsai/src/host.rs 24.8% <0.0%> (ø)

crates/risc0-bonsai/src/host.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@rakanalh rakanalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eyusufatik eyusufatik merged commit 3441722 into nightly Aug 14, 2024
12 checks passed
@eyusufatik eyusufatik deleted the esad/blocking-bonsai-client branch August 14, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blocking bonsai client
3 participants