Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash recovery #938

Merged
merged 24 commits into from
Aug 14, 2024
Merged

Crash recovery #938

merged 24 commits into from
Aug 14, 2024

Conversation

ercecan
Copy link
Member

@ercecan ercecan commented Aug 1, 2024

Description

WIP

Linked Issues

@ercecan ercecan marked this pull request as ready for review August 12, 2024 09:32
@rakanalh rakanalh changed the title WIP crash recovery Crash recovery Aug 12, 2024
@ercecan
Copy link
Member Author

ercecan commented Aug 12, 2024

I tested the functionality manually, any Ideas on how to implement tests?

Copy link

codecov bot commented Aug 12, 2024

Copy link
Member

@otaliptus otaliptus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My two cents

crates/prover/src/runner.rs Outdated Show resolved Hide resolved
crates/prover/src/runner.rs Outdated Show resolved Hide resolved
@ercecan ercecan requested a review from otaliptus August 12, 2024 12:58
Copy link
Member

@eyusufatik eyusufatik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we talked about what to change f2f

@ercecan ercecan requested a review from eyusufatik August 13, 2024 21:25
@ercecan
Copy link
Member Author

ercecan commented Aug 13, 2024

we talked about what to change f2f

done

Copy link
Member

@eyusufatik eyusufatik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking really good this time :)

just a few naming nits

crates/prover/src/runner.rs Outdated Show resolved Hide resolved
crates/prover/src/runner.rs Outdated Show resolved Hide resolved
crates/risc0-bonsai/src/host.rs Outdated Show resolved Hide resolved
@ercecan ercecan requested a review from eyusufatik August 14, 2024 08:07
@ercecan ercecan requested a review from eyusufatik August 14, 2024 09:19
@eyusufatik eyusufatik merged commit a680783 into nightly Aug 14, 2024
12 checks passed
@eyusufatik eyusufatik deleted the erce/risc0-bonsai-host-crash-recovery branch August 14, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Risc0BonsaiHost crash recovery
3 participants