-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sequencer scan L1 and resubmit mined commitments #928
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyusufatik
reviewed
Jul 30, 2024
With this PR, info logs became dirty with the following logs:
I suggest we make this particular logs in da debug level. |
yaziciahmet
force-pushed
the
yaziciahmet/scan-l1-on-reboot
branch
from
July 30, 2024 19:04
886a415
to
b7d3bb4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
yaziciahmet
force-pushed
the
yaziciahmet/scan-l1-on-reboot
branch
from
July 31, 2024 15:47
c792c57
to
96d09c4
Compare
eyusufatik
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We already had resubmission logic for commitments in local database. We also cross-checked whether if any pending marked commitments actually made it to mempool without sequencer being able to update its local database.
This PR adds also checks the potentially mined commitments. If a sequencer:
this causes sequencer to double commit the same l2 heights, which is a gas expensive operation.
Now we check the last committed L1 height to the head L1 block to see if there was any commitments included and update their pending status if so.
Linked Issues