Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deny.toml allowed licences #927

Merged
merged 1 commit into from
Jul 28, 2024
Merged

Conversation

eyusufatik
Copy link
Member

Description

comments out unused allow fields in the deny.toml

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.4%. Comparing base (13eed63) to head (d370012).

Additional details and impacted files

see 1 file with indirect coverage changes

Copy link
Contributor

@kpp kpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it that much required? I would imaging our ci breaks in the future bc new deps would require new licenses. LGTM

@eyusufatik
Copy link
Member Author

Is it that much required? I would imaging our ci breaks in the future bc new deps would require new licenses. LGTM

we can add those license when it's needed.

I needed to see which licenses we currently used, and for this reason in the future, it's a good idea to have the minimum viable set.

@eyusufatik eyusufatik merged commit c4d5e93 into nightly Jul 28, 2024
12 checks passed
@eyusufatik eyusufatik deleted the esad/update-deny-toml branch July 28, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants