Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WitnessUtils library improvement #926

Merged
merged 4 commits into from
Jul 30, 2024
Merged

WitnessUtils library improvement #926

merged 4 commits into from
Jul 30, 2024

Conversation

erdkocak
Copy link
Contributor

Description

  • Fixed a bug in determineWitnessLengthAt function.
  • Added tests for WitnessUtils library.
  • Created helper random generating Python scripts for random witness generation.

Linked Issues

Testing

  • Added unit and fuzz tests.

@codecov Codecov
Copy link

codecov bot commented Jul 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.4%. Comparing base (13eed63) to head (8f64640).
Report is 1 commits behind head on nightly.

Additional details and impacted files

@okkothejawa okkothejawa changed the title [WIP] WitnessUtils library improvement WitnessUtils library improvement Jul 29, 2024
@okkothejawa okkothejawa requested a review from eyusufatik July 30, 2024 07:46
@eyusufatik eyusufatik merged commit 4976e6e into nightly Jul 30, 2024
11 of 12 checks passed
@eyusufatik eyusufatik deleted the erdem/witnessUtils-testing-fix2 branch July 30, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpp kpp kpp left review comments

@okkothejawa okkothejawa okkothejawa approved these changes

@eyusufatik eyusufatik eyusufatik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests for WitnessUtils.lib
4 participants
@erdkocak @kpp @eyusufatik @okkothejawa