[WIP] WitnessUtils library improvements #919
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdkocak
changed the title
* CI Check genesis files (#903) * Test ci * Test ci 2 * Test ci 3 * Test ci 4 * Gitkeep state dir for temp genesis files * Test if ci works & revert python script * Remove comments of cis * Reduces unnecessary sleep * New script using git diff * Test ci works * Test ci * CI should work * Add genesis production mode (#905) * Add genesis production mode * Owner seperation * move e2e tests to different files (#906) * move e2e tests to different files * add comments to e2e tests * Implement debug_traceChain (#909) * Parse and validate parameters * Further block number validation & spawn sender job * Separate debug_Trace_by_block_number fn * Finalize debug_traceChain * Update error message * Recreate working set on each block * Add method to TestClient * Remove unused import * Lint * Decrease inactive time to 5 secs in tests * Fix test client * Add assertions to test * Only wait for block number of notifications * Separate handler fn * Pin cargo-binstall to 1.6.9 (#915) Co-authored-by: Jouz0 <[email protected]> * Add change upgradeability admin test (#913) * Add change upgradeability admin test * Call `owner` on ProxyAdmin * format fix --------- Co-authored-by: Erce Can Bektüre <[email protected]> Co-authored-by: Esad Yusuf Atik <[email protected]> Co-authored-by: Ahmet Yazıcı <[email protected]> Co-authored-by: jfldde <[email protected]> Co-authored-by: Jouz0 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
|
could you please fix this pr so that it does not start from a very old commit on nightly? makes it hard to review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
determineWitnessLengthAtfunction.WitnessUtilslibraryLinked Issues
Testing
Added unit and fuzz tests.