-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement debug_traceChain #909
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
bf97379
to
7b335d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
single nit. merge after fix. also, have you tested this query with something like ethers.js?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I wasn't able to. ethers.js doesn't support this out of the box. It supports custom rpc requests with custom method and params, and it supports custom subscription topics for I tested with wscat using the following command:
|
I am suspecting more and more if this is going to replace trace filter 😅 anyways let's call it the more the merrier |
* CI Check genesis files (#903) * Test ci * Test ci 2 * Test ci 3 * Test ci 4 * Gitkeep state dir for temp genesis files * Test if ci works & revert python script * Remove comments of cis * Reduces unnecessary sleep * New script using git diff * Test ci works * Test ci * CI should work * Add genesis production mode (#905) * Add genesis production mode * Owner seperation * move e2e tests to different files (#906) * move e2e tests to different files * add comments to e2e tests * Implement debug_traceChain (#909) * Parse and validate parameters * Further block number validation & spawn sender job * Separate debug_Trace_by_block_number fn * Finalize debug_traceChain * Update error message * Recreate working set on each block * Add method to TestClient * Remove unused import * Lint * Decrease inactive time to 5 secs in tests * Fix test client * Add assertions to test * Only wait for block number of notifications * Separate handler fn * Pin cargo-binstall to 1.6.9 (#915) Co-authored-by: Jouz0 <[email protected]> * Add change upgradeability admin test (#913) * Add change upgradeability admin test * Call `owner` on ProxyAdmin * format fix --------- Co-authored-by: Erce Can Bektüre <[email protected]> Co-authored-by: Esad Yusuf Atik <[email protected]> Co-authored-by: Ahmet Yazıcı <[email protected]> Co-authored-by: jfldde <[email protected]> Co-authored-by: Jouz0 <[email protected]>
Description
Implements debug_traceChain subscription rpc.
Linked Issues