Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary ledger rpcs #904

Merged
merged 25 commits into from
Aug 12, 2024
Merged

Conversation

ercecan
Copy link
Member

@ercecan ercecan commented Jul 19, 2024

Description

Removes unnecessary ledger rpcs

Linked Issues

@ercecan ercecan changed the title Remove unnecessary rpcs about batches and slots Remove unnecessary ledger rpcs Jul 19, 2024
@ercecan ercecan marked this pull request as ready for review July 19, 2024 11:37
@ercecan ercecan requested review from eyusufatik, kpp and rakanalh July 19, 2024 11:37
Copy link

codecov bot commented Jul 19, 2024

Copy link
Member

@eyusufatik eyusufatik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete ledger db tables please

crates/fullnode/tests/runner_reorg_tests.rs Show resolved Hide resolved
Copy link
Member

@eyusufatik eyusufatik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are good to go if you delete (now) unused ledger db tables

@eyusufatik
Copy link
Member

we are good to go if you delete (now) unused ledger db tables

left review so that it would be easier to review later on

@ercecan ercecan requested review from kpp and eyusufatik July 30, 2024 07:16
bin/citrea/tests/e2e/mod.rs Outdated Show resolved Hide resolved
@ercecan ercecan requested a review from kpp July 31, 2024 06:57
@ercecan ercecan requested a review from eyusufatik August 1, 2024 14:05
@ercecan ercecan self-assigned this Aug 12, 2024
@ercecan
Copy link
Member Author

ercecan commented Aug 12, 2024

Issue in question to remove unused ledger db tables: #976

@eyusufatik eyusufatik merged commit 22b54c9 into nightly Aug 12, 2024
12 checks passed
@eyusufatik eyusufatik deleted the erce/remove-unnecessary-ledger-rpcs branch August 12, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Ledger RPC methods we don't need
3 participants