Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Check genesis files #903

Merged
merged 12 commits into from
Jul 19, 2024
Merged

CI Check genesis files #903

merged 12 commits into from
Jul 19, 2024

Conversation

ercecan
Copy link
Member

@ercecan ercecan commented Jul 19, 2024

Description

Checks if make genesis was executed correctly

Linked Issues

@ercecan ercecan changed the title WIP Test ci CI Check genesis files Jul 19, 2024
@ercecan ercecan requested review from eyusufatik, okkothejawa and kpp and removed request for eyusufatik, okkothejawa and kpp July 19, 2024 07:59
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.0%. Comparing base (53bc3d4) to head (c94d79b).
Report is 3 commits behind head on nightly.

Additional details and impacted files

see 6 files with indirect coverage changes

Copy link
Contributor

@kpp kpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git diff --exit-code is actually better because we can diff even files not listed in paths

@ercecan ercecan requested review from kpp and okkothejawa July 19, 2024 09:52
@ercecan ercecan requested a review from eyusufatik July 19, 2024 09:52
@eyusufatik eyusufatik merged commit 57a326e into nightly Jul 19, 2024
12 checks passed
@eyusufatik eyusufatik deleted the erce/ci-check-genesis-files branch July 19, 2024 11:18
okkothejawa added a commit that referenced this pull request Jul 25, 2024
* CI Check genesis files (#903)

* Test ci

* Test ci 2

* Test ci 3

* Test ci 4

* Gitkeep state dir for temp genesis files

* Test if ci works & revert python script

* Remove comments of cis

* Reduces unnecessary sleep

* New script using git diff

* Test ci works

* Test ci

* CI should work

* Add genesis production mode (#905)

* Add genesis production mode

* Owner seperation

* move e2e tests to different files (#906)

* move e2e tests to different files

* add comments to e2e tests

* Implement debug_traceChain (#909)

* Parse and validate parameters

* Further block number validation & spawn sender job

* Separate debug_Trace_by_block_number fn

* Finalize debug_traceChain

* Update error message

* Recreate working set on each block

* Add method to TestClient

* Remove unused import

* Lint

* Decrease inactive time to 5 secs in tests

* Fix test client

* Add assertions to test

* Only wait for block number of notifications

* Separate handler fn

* Pin cargo-binstall to 1.6.9 (#915)

Co-authored-by: Jouz0 <[email protected]>

* Add change upgradeability admin test (#913)

* Add change upgradeability admin test

* Call `owner` on ProxyAdmin

* format fix

---------

Co-authored-by: Erce Can Bektüre <[email protected]>
Co-authored-by: Esad Yusuf Atik <[email protected]>
Co-authored-by: Ahmet Yazıcı <[email protected]>
Co-authored-by: jfldde <[email protected]>
Co-authored-by: Jouz0 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI for bytecode matching in genesis files against Foundry compilation outputs
4 participants