Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attempt fix flaky tests 2 #902

Merged
merged 1 commit into from
Jul 18, 2024
Merged

attempt fix flaky tests 2 #902

merged 1 commit into from
Jul 18, 2024

Conversation

eyusufatik
Copy link
Member

@eyusufatik eyusufatik commented Jul 18, 2024 •
edited
Loading

  • e2e::test_reopen_prover 151
  • evm::archival_state::test_archival_state 141
  • citrea::all_tests e2e::test_sequencer_fill_missing_da_blocks 127
  • citrea::all_tests evm::archival_state::test_archival_state 197
  • citrea::all_tests e2e::test_soft_confirmations_status_two_l1 133

Fixes

  • order of state and ledger db commit's were messed up in some PR

@codecov Codecov
Copy link

codecov bot commented Jul 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.0%. Comparing base (d1fea9d) to head (1d1b795).

Additional details and impacted files
Files Coverage Δ
crates/fullnode/src/runner.rs 74.6% <100.0%> (ø)
crates/prover/src/runner.rs 82.7% <100.0%> (ø)
crates/sequencer/src/sequencer.rs 90.2% <100.0%> (-0.1%) ⬇️

... and 1 file with indirect coverage changes

@eyusufatik eyusufatik merged commit d54cf83 into nightly Jul 18, 2024
11 checks passed
@eyusufatik eyusufatik deleted the esad/attempt-fix-flaky-tests-2 branch July 18, 2024 13:53
@eyusufatik eyusufatik mentioned this pull request Jul 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otaliptus otaliptus otaliptus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eyusufatik @otaliptus