Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check pending da commitments before resubmit #899

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

yaziciahmet
Copy link
Contributor

@yaziciahmet yaziciahmet commented Jul 17, 2024

Description

Before resubmission of pending commitments, we now check whether this already exists in DA mempool to avoid paying for a fee again.

Linked Issues-

@yaziciahmet yaziciahmet self-assigned this Jul 17, 2024
@yaziciahmet yaziciahmet requested a review from ercecan July 17, 2024 13:50
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 42.10526% with 11 lines in your changes missing coverage. Please review.

Project coverage is 79.0%. Comparing base (411bf9a) to head (592adb3).
Report is 2 commits behind head on nightly.

Additional details and impacted files
Files Coverage Δ
crates/sequencer/src/sequencer.rs 90.3% <42.1%> (-1.4%) ⬇️

... and 14 files with indirect coverage changes

@eyusufatik eyusufatik linked an issue Jul 17, 2024 that may be closed by this pull request
@yaziciahmet yaziciahmet force-pushed the yaziciahmet/commitment-resubmission-improvement branch from 592adb3 to 9798afb Compare July 17, 2024 18:38
@eyusufatik eyusufatik merged commit adaf2df into nightly Jul 18, 2024
21 checks passed
@eyusufatik eyusufatik deleted the yaziciahmet/commitment-resubmission-improvement branch July 18, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement proper resubmission of pending sequencer commitments
2 participants