Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix flaky tests #887

Merged
merged 8 commits into from
Jul 13, 2024
Merged

Attempt to fix flaky tests #887

merged 8 commits into from
Jul 13, 2024

Conversation

rakanalh
Copy link
Contributor

@rakanalh rakanalh commented Jul 12, 2024

Description

  • test_all_flow
  • test_gas_price_increase
  • test_soft_confirmations_status_two_l1
  • test_reopen_prover
  • test_prover_sync_with_commitments

Linked Issues

Causes:

  1. Full node sync & L1 processing does not happen properly if L2 is not synced yet
FullNode: citrea_fullnode::runner: Could not completely process sequencer commitments. Missing L2 blocks BatchNumber(4) - BatchNumber(6), msg = L2 range not synced yet
  1. Sometimes the Fullnode / Prover might see that an L2 block X is registered but trying to call EVM eth_block_number would not return the same block because the block itself hasn't been processed. The tests now sleep for 1 second in between receiving the L2 block & EVM execution.

Runs:

@rakanalh rakanalh self-assigned this Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 16 lines in your changes missing coverage. Please review.

Project coverage is 78.3%. Comparing base (f3a64b6) to head (1e8f1c3).
Report is 1 commits behind head on nightly.

Additional details and impacted files
Files Coverage Δ
crates/sequencer/src/commitment_controller.rs 100.0% <ø> (ø)
crates/sequencer/src/sequencer.rs 91.5% <66.6%> (-0.2%) ⬇️
crates/fullnode/src/runner.rs 74.2% <66.6%> (+0.3%) ⬆️

... and 2 files with indirect coverage changes

@rakanalh rakanalh force-pushed the rakanalh/fix-tests branch 2 times, most recently from b299f00 to 183f729 Compare July 12, 2024 21:46
@rakanalh rakanalh force-pushed the rakanalh/fix-tests branch from 183f729 to 7929e03 Compare July 12, 2024 21:53
@rakanalh rakanalh force-pushed the rakanalh/fix-tests branch 2 times, most recently from 6c19435 to 3ae1061 Compare July 13, 2024 17:31
@rakanalh rakanalh force-pushed the rakanalh/fix-tests branch from 3ae1061 to 4d057c1 Compare July 13, 2024 17:46
@rakanalh rakanalh requested review from kpp, eyusufatik and ercecan July 13, 2024 18:16
Copy link
Member

@eyusufatik eyusufatik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please comment out test tracing init lines and we are good to go

@rakanalh rakanalh merged commit f634146 into nightly Jul 13, 2024
11 checks passed
@rakanalh rakanalh deleted the rakanalh/fix-tests branch July 13, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_all_flow is flaky
2 participants