-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prev_hash to soft confirmations #873
Conversation
108e246
to
5ca55c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work. only one problem, we pass state root = 0 to all stf modules in the begin_soft_confirmation_hook now. I mostly addressed this in my comments
crates/sovereign-sdk/module-system/sov-modules-api/src/hooks.rs
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
Description
Linked Issues