Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prev_hash to soft confirmations #873

Merged
merged 26 commits into from
Jul 14, 2024
Merged

Add prev_hash to soft confirmations #873

merged 26 commits into from
Jul 14, 2024

Conversation

rakanalh
Copy link
Contributor

Description

Linked Issues

@rakanalh rakanalh marked this pull request as ready for review July 10, 2024 20:03
@rakanalh rakanalh force-pushed the rakanalh/prev-hash branch from 108e246 to 5ca55c4 Compare July 10, 2024 22:30
@rakanalh rakanalh self-assigned this Jul 10, 2024
Copy link
Member

@eyusufatik eyusufatik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work. only one problem, we pass state root = 0 to all stf modules in the begin_soft_confirmation_hook now. I mostly addressed this in my comments

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 41 lines in your changes missing coverage. Please review.

Project coverage is 78.3%. Comparing base (f634146) to head (7d1a679).

Additional details and impacted files
Files Coverage Δ
bin/citrea/src/test_rpc.rs 99.7% <100.0%> (+<0.1%) ⬆️
crates/primitives/src/error.rs 0.0% <ø> (ø)
crates/sequencer-client/src/lib.rs 100.0% <100.0%> (ø)
crates/sequencer/src/sequencer.rs 91.5% <100.0%> (+<0.1%) ⬆️
...reign-sdk/full-node/db/sov-db/src/ledger_db/mod.rs 95.9% <100.0%> (+<0.1%) ⬆️
...ereign-sdk/full-node/db/sov-db/src/schema/types.rs 76.1% <100.0%> (ø)
...vereign-sdk/full-node/sov-stf-runner/src/runner.rs 20.9% <100.0%> (+0.2%) ⬆️
...ign-sdk/module-system/sov-modules-api/src/hooks.rs 82.1% <100.0%> (-4.7%) ⬇️
...sovereign-sdk/rollup-interface/src/node/rpc/mod.rs 91.3% <ø> (ø)
...p-interface/src/state_machine/soft_confirmation.rs 97.3% <100.0%> (-0.2%) ⬇️
... and 13 more

... and 1 file with indirect coverage changes

@rakanalh rakanalh requested a review from eyusufatik July 11, 2024 22:37
@rakanalh rakanalh requested a review from eyusufatik July 14, 2024 10:00
@rakanalh rakanalh merged commit d4e597b into nightly Jul 14, 2024
11 checks passed
@rakanalh rakanalh deleted the rakanalh/prev-hash branch July 14, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add prev_hash to soft confirmations
3 participants