Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent rpc response case #867

Merged
merged 9 commits into from
Jul 10, 2024

Conversation

yaziciahmet
Copy link
Contributor

Description

Made all RPC responses in camel case, even the possibly unused ones.

Linked Issues

@yaziciahmet yaziciahmet added the T - bug Something isn't working label Jul 9, 2024
@yaziciahmet yaziciahmet self-assigned this Jul 9, 2024
@yaziciahmet yaziciahmet force-pushed the yaziciahmet/consistent-rpc-response-case branch from f65281d to 13fcbf0 Compare July 9, 2024 22:47
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.3%. Comparing base (97c1d36) to head (f12d068).
Report is 1 commits behind head on nightly.

Additional details and impacted files
Files Coverage Δ
bin/citrea/src/test_rpc.rs 99.7% <100.0%> (ø)
crates/ethereum-rpc/src/lib.rs 80.5% <ø> (ø)
crates/sequencer-client/src/lib.rs 100.0% <ø> (ø)
...ereign-sdk/full-node/db/sov-db/src/schema/types.rs 73.3% <100.0%> (ø)
...sovereign-sdk/rollup-interface/src/node/rpc/mod.rs 91.3% <ø> (ø)

... and 4 files with indirect coverage changes

@yaziciahmet yaziciahmet requested a review from kpp July 10, 2024 08:07
Copy link
Contributor

@kpp kpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@eyusufatik maybe we can fix #716 here?

@eyusufatik
Copy link
Member

#838

let's merge this

that can be done in any other pr haha

@eyusufatik eyusufatik merged commit 64c7dd4 into nightly Jul 10, 2024
11 checks passed
@eyusufatik eyusufatik deleted the yaziciahmet/consistent-rpc-response-case branch July 10, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T - bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent RPC response cases
3 participants