Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use verifier in citrea-stf #860

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Use verifier in citrea-stf #860

merged 1 commit into from
Jul 8, 2024

Conversation

rakanalh
Copy link
Contributor

@rakanalh rakanalh commented Jul 6, 2024

Description

This is just copy pasting the StateTransitionVerifier into a module inside Citrea-STF which should be sufficient for us to customize rather than updating the sov-sdk version.

Thoughts @eyusufatik?

Linked Issues

@rakanalh rakanalh self-assigned this Jul 6, 2024
@rakanalh rakanalh requested a review from eyusufatik July 6, 2024 17:42
Copy link

codecov bot commented Jul 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 63 lines in your changes missing coverage. Please review.

Project coverage is 78.2%. Comparing base (478e470) to head (0319174).

Additional details and impacted files
Files Coverage Δ
crates/citrea-stf/src/verifier.rs 0.0% <0.0%> (ø)

... and 1 file with indirect coverage changes

@eyusufatik
Copy link
Member

eyusufatik commented Jul 6, 2024

Makes sense

can you also update our guest code (bin/citrea/provers)

@rakanalh
Copy link
Contributor Author

rakanalh commented Jul 7, 2024

Makes sense

can you also update our guest code (bin/citrea/provers)

That's the beauty of it,,, these don't need any update because they don't import StateTransitionVerifier from sov-stf-runner. They import StfVerifier from citrea-stf

let stf_verifier = StfVerifier::new(stf, MockDaVerifier {});

@eyusufatik eyusufatik merged commit 2914bbf into nightly Jul 8, 2024
11 checks passed
@eyusufatik eyusufatik deleted the rakanalh/verifier-crate branch July 8, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move STFVerifier to its own crate
2 participants