Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use borsh to interact with guest code #851

Merged
merged 20 commits into from
Jul 10, 2024
Merged

Use borsh to interact with guest code #851

merged 20 commits into from
Jul 10, 2024

Conversation

kpp
Copy link
Contributor

@kpp kpp commented Jul 4, 2024

Description

Linked Issues

Testing

Need to run prove and verify.

@eyusufatik
Copy link
Member

files changed 47

o_o

@kpp kpp force-pushed the kpp/guest_borsh branch from 3cd061e to 5dc645d Compare July 4, 2024 14:19
@kpp kpp mentioned this pull request Jul 9, 2024
@kpp kpp self-assigned this Jul 9, 2024
@kpp kpp marked this pull request as ready for review July 9, 2024 14:38
@kpp kpp changed the title WIP: Use borsh to interact with guest code Use borsh to interact with guest code Jul 9, 2024
@kpp kpp force-pushed the kpp/guest_borsh branch from 82fd001 to 1d0bc16 Compare July 9, 2024 18:12
@kpp kpp changed the title Use borsh to interact with guest code [WIP] Use borsh to interact with guest code Jul 9, 2024
crates/bitcoin-da/src/verifier.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 69.32668% with 123 lines in your changes missing coverage. Please review.

Project coverage is 78.2%. Comparing base (f43cae1) to head (27694c9).
Report is 11 commits behind head on nightly.

Additional details and impacted files
Files Coverage Δ
crates/bitcoin-da/src/helpers/test_utils.rs 100.0% <100.0%> (ø)
crates/bitcoin-da/src/service.rs 60.2% <100.0%> (+0.3%) ⬆️
crates/bitcoin-da/src/spec/block.rs 23.0% <ø> (ø)
crates/bitcoin-da/src/verifier.rs 97.0% <100.0%> (+<0.1%) ⬆️
crates/fullnode/src/runner.rs 75.5% <100.0%> (+0.7%) ⬆️
crates/prover/src/runner.rs 74.0% <ø> (+0.6%) ⬆️
crates/sequencer/src/sequencer.rs 91.7% <100.0%> (+0.6%) ⬆️
...ates/sovereign-sdk/adapters/mock-da/src/service.rs 95.2% <ø> (-1.2%) ⬇️
...overeign-sdk/adapters/mock-da/src/types/address.rs 96.3% <ø> (+1.8%) ⬆️
...es/sovereign-sdk/adapters/mock-da/src/types/mod.rs 86.2% <100.0%> (+13.7%) ⬆️
... and 50 more

... and 6 files with indirect coverage changes

@kpp kpp changed the title [WIP] Use borsh to interact with guest code Use borsh to interact with guest code Jul 9, 2024
@kpp kpp requested a review from rakanalh July 9, 2024 18:56
@kpp kpp requested a review from eyusufatik July 9, 2024 18:56
@rakanalh
Copy link
Contributor

rakanalh commented Jul 9, 2024

files changed 47

o_o

84 now 😅

@eyusufatik
Copy link
Member

In test test_all_flow

Proof structure

  • Proof 1
    • L2 blocks [1, 4]
      • 2 transactions in block 3, 1 transaction in block 4
  • Proof 2
    • L2 blocks [5, 8]
      • 2 transactions in block 7

kpp/guest_borsh

Running sequencer commitments in DA slot
going into apply_soft_confirmations_from_sequencer_commitments
out of apply_soft_confirmations_from_sequencer_commitments
user cycles: 24164419
total cycles: 35651584
segments: 34
test e2e::test_all_flow has been running for over 60 seconds
Running sequencer commitments in DA slot
going into apply_soft_confirmations_from_sequencer_commitments
out of apply_soft_confirmations_from_sequencer_commitments
user cycles: 19407593
total cycles: 29360128
segments: 28

nightly

Running sequencer commitments in DA slot
going into apply_soft_confirmations_from_sequencer_commitments
test e2e::test_all_flow has been running for over 60 seconds
out of apply_soft_confirmations_from_sequencer_commitments
user cycles: 31174218
total cycles: 43122688
segments: 42
Running sequencer commitments in DA slot
going into apply_soft_confirmations_from_sequencer_commitments
out of apply_soft_confirmations_from_sequencer_commitments
user cycles: 25686951
total cycles: 35651584
segments: 34

crates/bitcoin-da/src/spec/header.rs Outdated Show resolved Hide resolved
crates/bitcoin-da/src/spec/header.rs Outdated Show resolved Hide resolved
crates/bitcoin-da/src/spec/transaction.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@rakanalh rakanalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eyusufatik eyusufatik merged commit 6b2f52d into nightly Jul 10, 2024
8 of 10 checks passed
@eyusufatik eyusufatik deleted the kpp/guest_borsh branch July 10, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use Borsh for input deserialization and output deserialization
3 participants