Convert tx hash bytes into hex #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakanalh
force-pushed
the
rakan/serialize-txs
branch
from
04290e6 to
9056c29
Compare
kpp
requested changes
Apr 4, 2024
rakanalh
force-pushed
the
rakan/serialize-txs
branch
from
0a7e756 to
33b5af7
Compare
|
@kpp @eyusufatik I messed up something during a merge from nightly so i had to force push. But PR is ready again for review. |
eyusufatik
reviewed
Apr 8, 2024
kpp
reviewed
Apr 8, 2024
eyusufatik
approved these changes
Apr 10, 2024
eyusufatik
requested review from
kpp
and removed request for
kpp,
ercecan and
otaliptus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a serializer to the
txsfield ofSoftBatchResponseto make sure the fields are converted from a vector of bytes into a hex representation of the value.Linked Issues
Testing
Docs
N/A