Improve timestamp handling #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpp
requested changes
Apr 3, 2024
kpp
reviewed
Apr 3, 2024
eyusufatik
requested changes
Apr 3, 2024
crates/soft-confirmation-rule-enforcer/src/tests/query_tests.rs
Outdated
Show resolved
Hide resolved
crates/soft-confirmation-rule-enforcer/src/tests/hooks_tests.rs
Outdated
Show resolved
Hide resolved
eyusufatik
requested changes
Apr 3, 2024
crates/sovereign-sdk/rollup-interface/src/state_machine/soft_confirmation.rs
Outdated
Show resolved
Hide resolved
eyusufatik
approved these changes
Apr 4, 2024
eyusufatik
approved these changes
Apr 4, 2024
kpp
approved these changes
Apr 4, 2024
rakanalh
added a commit
that referenced
this pull request
Apr 6, 2024
* Add timestamp field * Pass timestamp value * Apply timestamp rule * Add block time delta to timestamp * Remove "genesis_timestamp" field * Add timestamp to SoftBatchResponse * Fix all tests * Remove block timestamp delta field * Use chrono to set current timestamp * Set edition in rustfmt * Fix tests * Update docs * Add soft confirmation rule enforce timestamp tests * Fix RPC tests * Remove set_timestamp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
timestampfieldtimestampto various soft confirmations related data structures & initialize it from latest block storage.Linked Issues
Testing
soft-confirmation-enforcercrate.Docs