Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sequencer: Produce empty soft confirmations in skipped DA blocks #309

Merged
merged 7 commits into from
Mar 28, 2024
Merged

Sequencer: Produce empty soft confirmations in skipped DA blocks #309

merged 7 commits into from
Mar 28, 2024

Conversation

kpp
Copy link
Contributor

@kpp kpp commented Mar 27, 2024 •
edited
Loading

Description

TODO:

  • Refactor code - create fn ChainwaySequencer::produce_l2_block
  • If DA blocks skipped - create empty l2 blocks for them
  • ChainwaySequencer::produce_l2_block - defensive programming to catch misuse

Linked Issues

Testing

make test

@kpp kpp requested a review from eyusufatik March 27, 2024 16:41
@kpp kpp marked this pull request as ready for review March 27, 2024 16:41
eyusufatik
eyusufatik previously approved these changes Mar 28, 2024
View reviewed changes
eyusufatik
eyusufatik previously approved these changes Mar 28, 2024
View reviewed changes
@eyusufatik eyusufatik merged commit 8e6bd2b into nightly Mar 28, 2024
4 checks passed
@eyusufatik eyusufatik deleted the kpp/empty_soft_conf branch March 28, 2024 11:52
@kpp kpp self-assigned this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyusufatik eyusufatik eyusufatik approved these changes

Assignees

@kpp kpp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sequencer: Produce empty soft confirmations to not skip a DA block
2 participants
@kpp @eyusufatik