Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update call + genesis + tests #277

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Update call + genesis + tests #277

merged 1 commit into from
Mar 21, 2024

Conversation

otaliptus
Copy link
Member

Description

Closes #232.

The reason of reth and our client returning different responses were the following:

  • Outdated ensure_fees function.
  • Genesis addresses not having enough balance for our extreme tests.
  • Difference of cfg_env.disable_block_gas_limit. We're keeping it disabled. (when enabled with all of the above, everything matches)

@otaliptus otaliptus marked this pull request as ready for review March 20, 2024 15:06
@otaliptus otaliptus requested a review from eyusufatik March 20, 2024 15:09
Copy link
Member

@eyusufatik eyusufatik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work

@eyusufatik eyusufatik merged commit db0d5de into nightly Mar 21, 2024
8 checks passed
@eyusufatik eyusufatik deleted the talip/update-eth-call branch March 21, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eth_call not checking block fee
2 participants