Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guest side proof fail #1653

Open
wants to merge 13 commits into
base: nightly
Choose a base branch
from
Open

guest side proof fail #1653

wants to merge 13 commits into from

Conversation

eyusufatik
Copy link
Member

Description

since risc0 guest side proof verification APIs only support proofs that are verifiable, we need to verify failing of proofs with host side verification API.

TODO:

  • figure out how to test this in e2e

Linked Issues

Fixes #1643

@eyusufatik eyusufatik marked this pull request as ready for review December 26, 2024 18:12
@auto-assign auto-assign bot requested a review from yaziciahmet December 26, 2024 18:12
Copy link

codecov bot commented Dec 26, 2024

@eyusufatik eyusufatik changed the title Esad/guest side proof fail guest side proof fail Dec 26, 2024
Copy link
Contributor

@jfldde jfldde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but for the small nit above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guest verify should not panic
3 participants