Bind ELF to ProofData #1647
Open
Bind ELF to ProofData #1647
+985
−258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyusufatik
reviewed
Dec 25, 2024
eyusufatik
reviewed
Dec 25, 2024
crates/sovereign-sdk/rollup-interface/src/state_machine/soft_confirmation.rs
Outdated
Show resolved
Hide resolved
eyusufatik
reviewed
Dec 25, 2024
yaziciahmet
requested changes
Jan 2, 2025
Comment on lines
678
to
680
| if let Err(e) = fork_manager.register_block(l2_height) { | ||
| panic!("Fork transition failed {}", e); | ||
| } |
There was a problem hiding this comment.
.expect("fork transition failed")
yaziciahmet
requested changes
Jan 2, 2025
crates/sovereign-sdk/full-node/sov-stf-runner/src/prover_service/mod.rs
Outdated
Show resolved
Hide resolved
Comment on lines
+10
to
+12
| #[cfg(feature = "testing")] | ||
| pub static FORKS: OnceLock<&'static [Fork]> = OnceLock::new(); | ||
|
|
There was a problem hiding this comment.
if this is made public for tests, then we can remove the not(testing) (testing) separation in the use_network_forks as it will no longer be used for testing
| @@ -108,6 +108,7 @@ pub fn run_circuit<DaV: DaVerifier, G: ZkvmGuest>( | |||
| if let Ok(data) = data { | |||
| match data { | |||
| DaDataLightClient::Complete(proof) => { | |||
| // TODO: don't panic here, ignore if cant extract | |||
| @@ -52,6 +54,10 @@ fn test_payable_contract_value() { | |||
|
|
|||
| #[test] | |||
| fn test_tx_request_fields_gas_fork1() { | |||
| // override nightly FORKS | |||
| static OVERRIDE_FORKS: [Fork; 1] = [Fork::new(SpecId::Fork1, 0)]; | |||
| FORKS.set(&OVERRIDE_FORKS).expect("couldnt set"); | |||
ercecan
reviewed
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked Issues