Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Block::l1FeeRate hex #1631

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Make Block::l1FeeRate hex #1631

merged 1 commit into from
Dec 20, 2024

Conversation

kpp
Copy link
Contributor

@kpp kpp commented Dec 20, 2024

Description

Make Block::l1FeeRate hex again. Revert back to b726a0a92ede040

Linked Issues

Testing

make test

@kpp kpp requested a review from eyusufatik as a code owner December 20, 2024 00:59
@auto-assign auto-assign bot requested a review from yaziciahmet December 20, 2024 00:59
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.5%. Comparing base (8c812ba) to head (18dab4c).
Report is 1 commits behind head on nightly.

Additional details and impacted files
Files with missing lines Coverage Δ
crates/evm/src/query.rs 89.7% <100.0%> (ø)

... and 4 files with indirect coverage changes

@eyusufatik eyusufatik merged commit aaa4be7 into nightly Dec 20, 2024
14 of 15 checks passed
@eyusufatik eyusufatik deleted the kpp/l1feerate_hex branch December 20, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyusufatik eyusufatik eyusufatik approved these changes

@yaziciahmet yaziciahmet Awaiting requested review from yaziciahmet

Assignees

@kpp kpp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ETH Block RPC response l1FeeRate hex
2 participants
@kpp @eyusufatik