Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix debug trace response #1629

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Fix debug trace response #1629

merged 5 commits into from
Dec 20, 2024

Conversation

exeokan
Copy link
Contributor

@exeokan exeokan commented Dec 19, 2024

Description

Returns TraceResult instead of GethTrace in debug_traceBlockByHash and debug_traceBlockByNumber handlers

Linked Issues

@eyusufatik eyusufatik requested a review from ercecan December 19, 2024 15:00
@eyusufatik
Copy link
Member

Looks ok. I need you to cross reference our response with an ethereum API.

I mean the actual json returned.

@exeokan exeokan marked this pull request as ready for review December 19, 2024 17:21
@exeokan exeokan requested a review from eyusufatik as a code owner December 19, 2024 17:21
@auto-assign auto-assign bot requested a review from jfldde December 19, 2024 17:21
@exeokan exeokan added the HOLD-MERGE PR is not draft but should not be merged yet label Dec 19, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.4%. Comparing base (d240484) to head (b7fca83).
Report is 3 commits behind head on nightly.

Files with missing lines Patch % Lines
crates/ethereum-rpc/src/lib.rs 66.6% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/ethereum-rpc/src/ethereum.rs 100.0% <ø> (ø)
crates/ethereum-rpc/src/trace.rs 78.9% <100.0%> (+1.3%) ⬆️
crates/evm/src/query.rs 89.7% <100.0%> (ø)
crates/ethereum-rpc/src/lib.rs 69.4% <66.6%> (-0.3%) ⬇️

... and 12 files with indirect coverage changes

@exeokan exeokan removed the HOLD-MERGE PR is not draft but should not be merged yet label Dec 20, 2024
@eyusufatik
Copy link
Member

gonna need to test this against blockscout :D

@eyusufatik eyusufatik merged commit 83a3536 into nightly Dec 20, 2024
12 of 14 checks passed
@eyusufatik eyusufatik deleted the ege/fix-debug-trace-response branch December 20, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyusufatik eyusufatik eyusufatik approved these changes

@kpp kpp kpp approved these changes

@ercecan ercecan Awaiting requested review from ercecan

@jfldde jfldde Awaiting requested review from jfldde

Assignees

@exeokan exeokan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix debug_trace* response type
3 participants
@exeokan @eyusufatik @kpp