Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix validate_and_check_DA_ID CI check #1624

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

jfldde
Copy link
Contributor

@jfldde jfldde commented Dec 18, 2024

@auto-assign auto-assign bot requested a review from rakanalh December 18, 2024 20:33
@jfldde jfldde changed the base branch from release-v0.5.5 to release-v0.5.6 December 18, 2024 20:33
@jfldde jfldde changed the base branch from release-v0.5.6 to release-v0.5.5 December 18, 2024 20:34
@jfldde jfldde force-pushed the fix-validate_and_check_DA_ID branch 2 times, most recently from a0db475 to a4f425a Compare December 18, 2024 20:38
@eyusufatik
Copy link
Member

so if we only check when ref is release-* we have two problems:

1 - we already do that in release CI, in repo vars we have an expected method id (which also needs to be changed a bit)
2 - we want to know if any pr is changing the commitment, so that we can have releases in an easier way

so if we can have the check method id ci for every pr and push to nightly, that would be awesome. is there a no fail no pass status for CI jobs? like a warning maybe

@jfldde jfldde force-pushed the fix-validate_and_check_DA_ID branch from a53626c to 584b474 Compare December 18, 2024 21:06
@jfldde jfldde changed the base branch from release-v0.5.5 to nightly December 18, 2024 21:07
@jfldde jfldde requested a review from eyusufatik as a code owner December 18, 2024 21:07
@jfldde
Copy link
Contributor Author

jfldde commented Dec 18, 2024

so if we only check when ref is release-* we have two problems:

1 - we already do that in release CI, in repo vars we have an expected method id (which also needs to be changed a bit) 2 - we want to know if any pr is changing the commitment, so that we can have releases in an easier way

so if we can have the check method id ci for every pr and push to nightly, that would be awesome. is there a no fail no pass status for CI jobs? like a warning maybe

This would run against any PR opened against release-v* or push to release-v* branches.

@jfldde jfldde added HOLD-MERGE PR is not draft but should not be merged yet DECISION-NEEDED the issue should be carefully evaluated for inclusion into the repo labels Dec 18, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.5%. Comparing base (9626b78) to head (7a0dc87).
Report is 2 commits behind head on nightly.

Additional details and impacted files

see 5 files with indirect coverage changes

@jfldde jfldde force-pushed the fix-validate_and_check_DA_ID branch from e23eb76 to 6ca5ae6 Compare December 20, 2024 14:13
@jfldde jfldde changed the title CI: Validate IDs against release-v* CI: Fix validate_and_check_DA_ID CI check Dec 20, 2024
@eyusufatik eyusufatik merged commit 6428659 into nightly Dec 20, 2024
14 of 15 checks passed
@eyusufatik eyusufatik deleted the fix-validate_and_check_DA_ID branch December 20, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DECISION-NEEDED the issue should be carefully evaluated for inclusion into the repo HOLD-MERGE PR is not draft but should not be merged yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix validate_and_check_DA_ID CI check
2 participants