Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify chunked txs #1618

Open
wants to merge 27 commits into
base: nightly
Choose a base branch
from
Open

Verify chunked txs #1618

wants to merge 27 commits into from

Conversation

rakanalh
Copy link
Contributor

Description

Linked Issues

Copy link
Member

@eyusufatik eyusufatik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to implement

BitcoinService::extract_relevant_blobs_with_proof line 993

and BitcoinVerifier::verify_transactions line 153

crates/light-client-prover/src/circuit.rs Outdated Show resolved Hide resolved
crates/light-client-prover/src/circuit.rs Outdated Show resolved Hide resolved
crates/light-client-prover/src/da_block_handler.rs Outdated Show resolved Hide resolved
@eyusufatik eyusufatik requested a review from kpp December 17, 2024 15:18
@rakanalh rakanalh marked this pull request as ready for review December 20, 2024 08:23
@auto-assign auto-assign bot requested a review from yaziciahmet December 20, 2024 08:23
crates/bitcoin-da/src/verifier.rs Outdated Show resolved Hide resolved
}
}
DaDataLightClient::Chunk(chunk) => {
wtxid_data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

realized there is a dos attack vector with our aproach. let me think of a solution

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 43.03030% with 94 lines in your changes missing coverage. Please review.

Project coverage is 78.0%. Comparing base (8feb715) to head (72bebeb).

Files with missing lines Patch % Lines
crates/light-client-prover/src/circuit.rs 57.1% 33 Missing ⚠️
crates/bitcoin-da/src/verifier.rs 0.0% 32 Missing ⚠️
crates/bitcoin-da/src/helpers/parsers.rs 0.0% 12 Missing ⚠️
crates/bitcoin-da/src/service.rs 50.0% 7 Missing ⚠️
crates/bitcoin-da/src/spec/blob.rs 33.3% 4 Missing ⚠️
crates/light-client-prover/src/da_block_handler.rs 0.0% 3 Missing ⚠️
...tes/sovereign-sdk/adapters/mock-da/src/verifier.rs 0.0% 3 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...c/helpers/builders/light_client_proof_namespace.rs 100.0% <100.0%> (ø)
...sovereign-sdk/adapters/mock-da/src/db_connector.rs 99.5% <100.0%> (ø)
...ates/sovereign-sdk/adapters/mock-da/src/service.rs 95.2% <100.0%> (+<0.1%) ⬆️
...es/sovereign-sdk/adapters/mock-da/src/types/mod.rs 72.9% <100.0%> (+1.8%) ⬆️
...ereign-sdk/full-node/db/sov-db/src/schema/types.rs 73.0% <ø> (ø)
...reign-sdk/rollup-interface/src/state_machine/da.rs 73.6% <ø> (ø)
...n-sdk/rollup-interface/src/state_machine/zk/mod.rs 93.7% <ø> (ø)
crates/light-client-prover/src/da_block_handler.rs 0.0% <0.0%> (ø)
...tes/sovereign-sdk/adapters/mock-da/src/verifier.rs 81.1% <0.0%> (-3.7%) ⬇️
crates/bitcoin-da/src/spec/blob.rs 73.1% <33.3%> (-5.3%) ⬇️
... and 4 more

... and 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Light client proof verify chunked txs
4 participants