-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set ZK constants in compile time #1613
Conversation
guests/risc0/batch-proof-bitcoin/src/bin/batch_proof_bitcoin.rs
Outdated
Show resolved
Hide resolved
crates/sovereign-sdk/rollup-interface/src/state_machine/zk/mod.rs
Outdated
Show resolved
Hide resolved
you can put a setting.json under .vscode under this pr I think. Also create a test_builds.env file unders guests/ so that people can see the env vars in the repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
option_env!, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update all evm tests to use fork1 spec unless we test for specific behaviour going from genesis to fork1
Description
Made certain variables constant in zk. Only environment variable needed is
CITREA_NETWORK
, and all the constant values are decided based on the network env value. ValidCITREA_NETWORK
values are:If no
CITREA_NETWORK
env variable is found, it defaults to nightly. And to make things more testable, if the network is nightly, the exact values for each constant value can be provided through env variable.Batch Proof:
Light Client Proof:
TODO:
Linked Issues
Testing
Describe how these changes were tested. If you've added new features, have you added unit tests?
Docs
Describe where this code is documented. If it changes a documented interface, have the docs been updated?