Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork1 tests v2 #1604

Merged
merged 17 commits into from
Dec 19, 2024
Merged

Fork1 tests v2 #1604

merged 17 commits into from
Dec 19, 2024

Conversation

ercecan
Copy link
Member

@ercecan ercecan commented Dec 12, 2024

Tests these => #1464 (comment)

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 85.36585% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.5%. Comparing base (d240484) to head (0dfe99d).
Report is 2 commits behind head on nightly.

Files with missing lines Patch % Lines
...src/smart_contracts/kzg_point_evaluation_caller.rs 80.7% 5 Missing ⚠️
crates/evm/src/evm/handler.rs 93.3% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/evm/src/evm/handler.rs 79.8% <93.3%> (+1.6%) ⬆️
...src/smart_contracts/kzg_point_evaluation_caller.rs 80.7% <80.7%> (ø)

... and 5 files with indirect coverage changes

crates/evm/src/evm/test_data/KZGPointEvaluation.sol Outdated Show resolved Hide resolved
crates/evm/src/tests/fork_tests.rs Outdated Show resolved Hide resolved
crates/evm/src/tests/fork_tests.rs Outdated Show resolved Hide resolved
crates/evm/src/tests/fork_tests.rs Show resolved Hide resolved
@eyusufatik
Copy link
Member

holding on to this pr until we get our upgrade prs merged. because disabling point evaluation precompile needs some changes unfortunately.

@eyusufatik eyusufatik added the HOLD-MERGE PR is not draft but should not be merged yet label Dec 16, 2024
crates/evm/src/evm/handler.rs Outdated Show resolved Hide resolved
@eyusufatik eyusufatik removed the HOLD-MERGE PR is not draft but should not be merged yet label Dec 19, 2024
@eyusufatik eyusufatik merged commit 8c812ba into nightly Dec 19, 2024
13 of 14 checks passed
@eyusufatik eyusufatik deleted the erce/fork1-tests-2 branch December 19, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants