Use bitcoincore-rpc reqwest transport #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
ercecan,
eyusufatik,
kpp,
rakanalh and
yaziciahmet
eyusufatik
approved these changes
Sep 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
eyusufatik
added a commit
that referenced
this pull request
Sep 24, 2024
* update package versions (#1119) * update release to install correct risc0 version (#1121) * make default rust version 1.79.0 in release (#1122) * make default rust version 1.79.0 * use home directory for rzup * fix rzup path (#1123) * Fix typo (#1129) * don't use rzup (#1139) * Update l1 fee overhead (#1137) Co-authored-by: eyusufatik <[email protected]> * Move sync blocks count (#1126) * Fullnode: bypass wallet check for bitcoin DA (#1128) * Add option to skip wallet check * Create bitcoin service based on wallet check requirement * Fix tests * Pass bool instead * E2E Add support for env (#1138) * E2E Add support for env * check if soft confirmation heights are sequential in zk (#1141) * change finality depth to 8 and change how depth is calculated (#1143) * change finality depth to 8 and change how depth is calculated * Fix prover test * fix test * fix release for macos * add DA_ID validation, release naming stadardization --------- Co-authored-by: jfldde <[email protected]> Co-authored-by: Cetin <[email protected]> * fix macos release ci (#1144) * Add make clean-all target (#1146) * Add clean-all target * Add clean-docker * add bitcoin da config for backup directory (#1148) * add bitcoin da config for backup directory * add new configs to bitcoin-regtest configs * use cargo manifest dir in tests to set tx backup dir * roman's comment * use get_tx_backup_dir in bitcoin da service tests * Change deposit script prefix (#1150) * Change deposit script prefix * Test fixes * Test bridge fix * Use bonsai retry macro (#1145) * include pending utxos in get_utxos (#1154) * Add cycle-diff script and perf CI (#1153) * Add cycle-diff script and perf CI * Set TARGET_PCT to 3 * Set cargo test package * Shellcheck * Rename to base_* * Temporarly run CI on this branch * Output generate to stdout as well * Remove redundant build step * Don't silence build output * Upload correct result file * Fix yml * Add debug * Use docker to run e2e tests * Remove debug * Remove branch trigger * Add NUM_RUNS and average * Don't check regression on Execution Time * Set bitcoincore-rev (#1155) * future proof da parsing in sequencer and prover (#1156) * parse seq comms future proof in zk (#1157) * Make trait verify parsed public (#1161) * full node fix l1 start height (#1160) * move prover last scanned l1 height table and functions to shared ledger ops * full node use last scan l1 table * Update crates/fullnode/src/runner.rs Co-authored-by: Erce Can Bektüre <[email protected]> --------- Co-authored-by: Erce Can Bektüre <[email protected]> * Remove redundant build (#1164) * Process L1 blocks in a different task. (#1163) * Process L1 blocks in a different task. This introduces handler for L1 blocks which is spawned as a separate task * Add DA block handler * Happy clippy * Move all L1 processing into L1BlockHandler * Remove uninformative log * Keep logic for retrying L1 blocks if L2 range is missing * Happy Clippy: 2 * Process L2 blocks in order * add some logs * Process blocks immediately and queue if failed * Import info * Fix logs * Process all L2 blocks in pending * more logs --------- Co-authored-by: eyusufatik <[email protected]> * Make l2 height of GetSoftConfirmationResponse public (#1165) * Further restrict eth_getLogs (#1166) * Further restrict eth_getLogs * Log test fix * Log test fix * Prover: improve L1 / L2 sync (#1168) * Separate L1 block sync * L2 worker to push to pending blocks * Enable prover simulation (#1171) * Enable prover simulation * Unneeded return * Use Mutex instead of RwLock --------- Co-authored-by: Esad Yusuf Atik <[email protected]> * Don't delete account code (#1179) * Don't delete account code * Don't charge l1 fee for delete acc.code * use BlockId in some evm queries (#1182) * use BlockId in some evm queries * Update checks.yml * Update checks.yml --------- Co-authored-by: Erce Can Bektüre <[email protected]> * Don't insert duplicate account codes (#1180) * Don't insert duplicate account codes * Don't charge l1 fee if code is already in Db * Fix lints * StorageInternalCache::exists -> contains_key * Revert exists/contains_key * Don't insert code on duplicates * Add validate_and_check_DA_ID job to checks.yml (#1177) * Add validate_and_check_DA_ID job * Try share build * Fix path * Use smaller instance * add locked flag to cargo-udeps (#1187) * add locked flag to cargo-udeps * change order of flags * fix usage of wrong block env (#1189) * Optimize rocksdb (#1127) * Optimize rocksdb * Set LRU cache * Remove unused ledger tables (#1131) * Remove unused ledger tables * record deposit data, why wouldn't we?< * lint --------- Co-authored-by: Esad Yusuf Atik <[email protected]> Co-authored-by: eyusufatik <[email protected]> * Complete test implementation (#1124) * Complete test implementation * Add comment * Wait for proof * Sort before checking range * Send shutdown message to da queue * Cleanup * Remove docker from prover test config * Restore prefixes * Update bin/citrea/tests/bitcoin_e2e/tests/prover_test.rs Co-authored-by: jfldde <[email protected]> * Restore inscribes_queue * Use finality depth to generate 1 finalized DA height * Unwrap or else * Update crates/prover/src/da_block_handler.rs * Mention L1 height in log * Remove unnecessary sort --------- Co-authored-by: jfldde <[email protected]> * Add l1 status to citrea_syncStatus (#1192) * add ledger_db to get_ethereum_rpc * add ledger_db to ethereum_rpc::Ethereum, get l1 block numbers * changed CitreaStatus and add err handling * fix test * format code, remove unused imports * add l1 sync test * rename CitreaStatus, use finalized l1 height * make requests async * switch from spawn to join * fix error names + use ledger db for head l2 * fix lint --------- Co-authored-by: eyusufatik <[email protected]> * Use bitcoincore-rpc reqwest transport (#1195) * Remove redundant install (#1196) * use tick interval in sequencer (#1197) * use tick interval in sequencer * fix rakan's comment * fix test_minimum_base_fee test * make ethers.js test less flaky * use bigger machine for build ci * try fixing ethers.js ci * log ethers.js error * fix ethers.js test * Process missed da blocks on start (#1201) * Process missed da blocks on start * Simulate with a test * Restore deleted by mistake code * Disable log * some improvements --------- Co-authored-by: eyusufatik <[email protected]> * Fix block number event bug in light client (#1203) * Fix block number event bug in light client * Test fixes * Further test fix * Avoid calling spawn_da_queue for full node (#1204) * dont spawn_da_queue for full nodes * format * edit comment * disable healthcheck (#1205) * CI: Checks cleanup (#1209) * SKIP_GUEST_BUILD in udeps * Remove Rust toolchain from web3 tests * Cleanup components and warning * Use SHORT_PREFIX env in CI (#1206) * Use SHORT_PREFIX env to reduce prefix length. Reduce nonce finding difficulty, speeds up bitcoin_e2e tests and addresses related flakiness. * Use SHORT_PREFIX for test and coverage only * Revet short backtraces * Revert redundant to_vec * Revert import in bitcoin-da * add command explaining prefix stuff * Merge comments --------- Co-authored-by: eyusufatik <[email protected]> * Customisable workflow dispatch name (#1207) * Check compressed state diff size for generating proofs (#1212) * Check compressed state diff size for generating proofs * Better naming * Clarify why we check against compressed state diff size * Use const in bitcoinda * Fmt * Move const to primitives * Dprint * Fix * Testnet Instructions (#1219) * create run-testnet.dm * add testnet full node config * add run-testnet.md * make initial doc * update instructions * fix curls * add testnet genesis * remove todo * Update readme for testnet (#1225) * Update readme for testnet * Better text --------- Co-authored-by: Rakan Al-Huneiti <[email protected]> Co-authored-by: Erce Can Bektüre <[email protected]> Co-authored-by: jfldde <[email protected]> Co-authored-by: Cetin <[email protected]> Co-authored-by: okkothejawa <[email protected]> Co-authored-by: Roman <[email protected]> Co-authored-by: Ege Okan Ünaldı <[email protected]> Co-authored-by: Ömer Talip Akalın <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bitcoincore-rpcnewreqwesttransport Use custom Reqwest transport rust-bitcoincore-rpc#5net&&rpcto e2e bitcoin node