-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass L1 fee rate through Context and modify Stf ( and its blueprint) #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypes make more sense
auto-assign
bot
requested review from
ercecan,
jfldde,
kpp,
rakanalh and
yaziciahmet
August 29, 2024 09:17
kpp
reviewed
Aug 29, 2024
crates/sovereign-sdk/module-system/sov-modules-stf-blueprint/src/stf_blueprint.rs
Outdated
Show resolved
Hide resolved
kpp
reviewed
Aug 29, 2024
kpp
reviewed
Aug 29, 2024
kpp
reviewed
Aug 29, 2024
crates/sovereign-sdk/module-system/sov-modules-stf-blueprint/src/stf_blueprint.rs
Outdated
Show resolved
Hide resolved
kpp
approved these changes
Aug 29, 2024
eyusufatik
force-pushed
the
esad/modify-context
branch
from
August 29, 2024 14:52
ae60f60
to
2d0176a
Compare
eyusufatik
force-pushed
the
esad/modify-context
branch
from
August 30, 2024 07:53
70a5400
to
ad2ec14
Compare
ercecan
approved these changes
Aug 30, 2024
rakanalh
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
To resolve RPC tests:
|
no I really broke them this time :D fixing one by one |
eyusufatik
commented
Aug 30, 2024
crates/sovereign-sdk/module-system/sov-modules-stf-blueprint/src/stf_blueprint.rs
Outdated
Show resolved
Hide resolved
crates/sovereign-sdk/module-system/sov-modules-stf-blueprint/src/stf_blueprint.rs
Show resolved
Hide resolved
crates/sovereign-sdk/module-system/sov-modules-stf-blueprint/src/stf_blueprint.rs
Show resolved
Hide resolved
ok. in the end, I really needed it because I added a line to a file and all the numbers in the expected output was shifted by one |
jfldde
pushed a commit
that referenced
this pull request
Aug 30, 2024
…1053) * rename SignedSoftConfirmationBatch to SignedSoftConfirmation * rename UnignedSoftConfirmationBatch to UnsignedSoftConfirmation * add l2 height to soft confirmations * add l1 fee rate and active spec to context * fixes for the last commit * modify ApplySoftConfirmationHooks and StfBluePrint function so that types make more sense * make new changes work in the sequencer * test and lint fixes * remove l1 fee rate from evm state * fix ci * remove comment and unnecessary clone * fix ci again * fix ci again * change function signature of ApplySoftConfirmationHooks * Inline verify_txs_stateless and decode_txs to reduce .collect() * fix rpc tests, add issue urls to TODOs * trybuild=overwrite --------- Co-authored-by: Roman Proskuryakoff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We used to write L1 fee rate to state and read from it in EVM's sov-call function. Now we pass it through the context which is passed to dispatch of sov-calls. Everywhere else can access the L1 fee rate throught HooksSoftConfirmatinInfo.
While working on the PR I realized we made some mistakes on the typings of hooks and functions of the StfBluePrint so I also fixed that.
Linked Issues
Testing
Will fix test compilation errors