Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse BatchProof/LightClient data from DA #1037

Merged
merged 16 commits into from
Sep 3, 2024
Merged

Conversation

kpp
Copy link
Contributor

@kpp kpp commented Aug 22, 2024

Description

Linked Issues

Testing

Describe how these changes were tested. If you've added new features, have you added unit tests?

Docs

Describe where this code is documented. If it changes a documented interface, have the docs been updated?

@kpp kpp changed the title [WIP] Parse BatchProof from DA [WIP] Parse BatchProof/LightClient data from DA Aug 23, 2024
@kpp kpp marked this pull request as ready for review August 26, 2024 15:12
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 36.64596% with 102 lines in your changes missing coverage. Please review.

Project coverage is 77.5%. Comparing base (ae63fa3) to head (959a44e).
Report is 3 commits behind head on nightly.

Files with missing lines Patch % Lines
crates/bitcoin-da/src/service.rs 0.0% 91 Missing ⚠️
crates/bitcoin-da/src/helpers/parsers.rs 0.0% 4 Missing ⚠️
crates/fullnode/src/runner.rs 84.0% 4 Missing ⚠️
...ates/sovereign-sdk/utils/rng-da-service/src/lib.rs 0.0% 3 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/bitcoin-da/src/helpers/compression.rs 100.0% <ø> (ø)
crates/bitcoin-da/src/helpers/merkle_tree.rs 95.3% <ø> (ø)
crates/bitcoin-da/src/helpers/mod.rs 64.0% <ø> (ø)
...ates/sovereign-sdk/adapters/mock-da/src/service.rs 95.6% <100.0%> (+0.1%) ⬆️
...reign-sdk/rollup-interface/src/node/services/da.rs 0.0% <ø> (ø)
...reign-sdk/rollup-interface/src/state_machine/da.rs 68.8% <100.0%> (+0.8%) ⬆️
...ates/sovereign-sdk/utils/rng-da-service/src/lib.rs 10.3% <0.0%> (-0.2%) ⬇️
crates/bitcoin-da/src/helpers/parsers.rs 72.6% <0.0%> (-0.2%) ⬇️
crates/fullnode/src/runner.rs 76.4% <84.0%> (-0.2%) ⬇️
crates/bitcoin-da/src/service.rs 38.5% <0.0%> (-4.9%) ⬇️

... and 2 files with indirect coverage changes

@kpp kpp changed the title [WIP] Parse BatchProof/LightClient data from DA Parse BatchProof/LightClient data from DA Aug 27, 2024
@kpp kpp requested review from rakanalh, eyusufatik and ercecan August 27, 2024 12:45
crates/bitcoin-da/src/service.rs Outdated Show resolved Hide resolved
crates/bitcoin-da/src/service.rs Outdated Show resolved Hide resolved
crates/bitcoin-da/src/service.rs Outdated Show resolved Hide resolved
bin/citrea/tests/e2e/syncing.rs Outdated Show resolved Hide resolved
crates/bitcoin-da/src/service.rs Outdated Show resolved Hide resolved
crates/bitcoin-da/src/service.rs Outdated Show resolved Hide resolved
crates/bitcoin-da/src/service.rs Outdated Show resolved Hide resolved
crates/bitcoin-da/src/service.rs Outdated Show resolved Hide resolved
crates/bitcoin-da/src/service.rs Outdated Show resolved Hide resolved
crates/bitcoin-da/src/service.rs Outdated Show resolved Hide resolved
crates/bitcoin-da/src/service.rs Outdated Show resolved Hide resolved
crates/bitcoin-da/src/service.rs Outdated Show resolved Hide resolved
crates/bitcoin-da/src/service.rs Outdated Show resolved Hide resolved
crates/bitcoin-da/src/service.rs Outdated Show resolved Hide resolved
Co-authored-by: Erce Can Bektüre <[email protected]>
@kpp kpp added the HOLD-MERGE PR is not draft but should not be merged yet label Aug 29, 2024
@kpp kpp removed the HOLD-MERGE PR is not draft but should not be merged yet label Sep 3, 2024
@eyusufatik eyusufatik merged commit fc2f182 into nightly Sep 3, 2024
12 checks passed
@eyusufatik eyusufatik deleted the kpp/dadata_parsing branch September 3, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prover fails to deserialize sequencer commitment Full node: get zkproof from chunked da data
5 participants