Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAIN] Enable blocking RPC methods #1033

Closed
wants to merge 3 commits into from
Closed

[MAIN] Enable blocking RPC methods #1033

wants to merge 3 commits into from

Conversation

rakanalh
Copy link
Contributor

Description

Linked Issues

@codecov Codecov
Copy link

codecov bot commented Aug 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 51.66667% with 29 lines in your changes missing coverage. Please review.

Project coverage is 79.2%. Comparing base (6e1f698) to head (7ca42de).
Report is 1 commits behind head on devnet-freeze.

Files with missing lines Patch % Lines
...odule-system/sov-modules-macros/src/rpc/rpc_gen.rs 51.6% 29 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/evm/src/query.rs 86.4% <ø> (ø)
...odule-system/sov-modules-macros/src/rpc/rpc_gen.rs 85.0% <51.6%> (-7.7%) ⬇️

... and 1 file with indirect coverage changes

@kpp
Copy link
Contributor

kpp commented Aug 21, 2024

deny - just ignore those RUSTSEC-2024-0347 RUSTSEC-2024-0362

@rakanalh rakanalh force-pushed the rakanalh/main-blocking-rpc-methods branch from 1f0cc04 to 7ca42de Compare August 21, 2024 15:55
@eyusufatik eyusufatik added the HOLD-MERGE PR is not draft but should not be merged yet label Aug 21, 2024
@eyusufatik eyusufatik closed this Sep 17, 2024
@rakanalh rakanalh deleted the rakanalh/main-blocking-rpc-methods branch September 17, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyusufatik eyusufatik eyusufatik approved these changes

@kpp kpp kpp approved these changes

@ercecan ercecan Awaiting requested review from ercecan

@jfldde jfldde Awaiting requested review from jfldde

@yaziciahmet yaziciahmet Awaiting requested review from yaziciahmet

Assignees

@rakanalh rakanalh

Labels
HOLD-MERGE PR is not draft but should not be merged yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rakanalh @kpp @eyusufatik