Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable blocking RPC methods #1032

Merged
merged 8 commits into from
Aug 27, 2024
Merged

Conversation

rakanalh
Copy link
Contributor

crates/evm/src/query.rs Outdated Show resolved Hide resolved
crates/evm/src/query.rs Outdated Show resolved Hide resolved
crates/evm/src/query.rs Outdated Show resolved Hide resolved
crates/evm/src/query.rs Outdated Show resolved Hide resolved
@kpp
Copy link
Contributor

kpp commented Aug 21, 2024

The thing is I doubt we will ever have async endpoints. We would have need them for things like going to network to get some info, but due do the nature of our architecture that's not the case...

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 75.33333% with 37 lines in your changes missing coverage. Please review.

Project coverage is 77.8%. Comparing base (a5f9485) to head (8437045).
Report is 11 commits behind head on nightly.

Files Patch % Lines
...odule-system/sov-modules-macros/src/rpc/rpc_gen.rs 51.6% 29 Missing ⚠️
crates/sequencer/src/rpc.rs 86.9% 3 Missing ⚠️
...vereign-sdk/full-node/sov-ledger-rpc/src/server.rs 92.5% 3 Missing ⚠️
crates/ethereum-rpc/src/lib.rs 90.0% 2 Missing ⚠️
Additional details and impacted files
Files Coverage Δ
crates/ethereum-rpc/src/ethereum.rs 100.0% <ø> (ø)
crates/ethereum-rpc/src/gas_price/gas_oracle.rs 80.5% <100.0%> (+0.6%) ⬆️
crates/evm/src/query.rs 86.3% <ø> (ø)
crates/sequencer/src/sequencer.rs 90.7% <ø> (+<0.1%) ⬆️
crates/ethereum-rpc/src/lib.rs 87.4% <90.0%> (-1.5%) ⬇️
crates/sequencer/src/rpc.rs 70.7% <86.9%> (+0.3%) ⬆️
...vereign-sdk/full-node/sov-ledger-rpc/src/server.rs 97.4% <92.5%> (-1.1%) ⬇️
...odule-system/sov-modules-macros/src/rpc/rpc_gen.rs 84.7% <51.6%> (-7.6%) ⬇️

... and 30 files with indirect coverage changes

* Use parking_lot instead of tokio Mutex

* Register blocking methods

* Turn async into blocking in sequencer

* Ledger RPC are definitely blocking
@eyusufatik eyusufatik merged commit fa1d68d into nightly Aug 27, 2024
12 checks passed
@eyusufatik eyusufatik deleted the rakanalh/blocking-rpc-methods branch August 27, 2024 08:10
jfldde pushed a commit that referenced this pull request Aug 30, 2024
* Enable blocking RPC methods

* Only add async trait marker if there are async methods

* Remove async from method

* Remove blocking marker

* Revert Cargo.lock files

* Silence clippy

* Convert async RPC into blocking RPC (#1042)

* Use parking_lot instead of tokio Mutex

* Register blocking methods

* Turn async into blocking in sequencer

* Ledger RPC are definitely blocking

* Fix Mutex type
@kpp kpp mentioned this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve long running RPC calls halting node sync
4 participants