-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable blocking RPC methods #1032
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
ercecan,
eyusufatik,
jfldde,
kpp and
yaziciahmet
August 21, 2024 14:17
rakanalh
commented
Aug 21, 2024
rakanalh
commented
Aug 21, 2024
kpp
reviewed
Aug 21, 2024
kpp
reviewed
Aug 21, 2024
kpp
reviewed
Aug 21, 2024
crates/sovereign-sdk/module-system/sov-modules-macros/src/rpc/rpc_gen.rs
Outdated
Show resolved
Hide resolved
kpp
approved these changes
Aug 21, 2024
The thing is I doubt we will ever have async endpoints. We would have need them for things like going to network to get some info, but due do the nature of our architecture that's not the case... |
* Use parking_lot instead of tokio Mutex * Register blocking methods * Turn async into blocking in sequencer * Ledger RPC are definitely blocking
kpp
approved these changes
Aug 26, 2024
jfldde
approved these changes
Aug 27, 2024
eyusufatik
approved these changes
Aug 27, 2024
jfldde
pushed a commit
that referenced
this pull request
Aug 30, 2024
* Enable blocking RPC methods * Only add async trait marker if there are async methods * Remove async from method * Remove blocking marker * Revert Cargo.lock files * Silence clippy * Convert async RPC into blocking RPC (#1042) * Use parking_lot instead of tokio Mutex * Register blocking methods * Turn async into blocking in sequencer * Ledger RPC are definitely blocking * Fix Mutex type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked Issues